I don't understand what's wrong with my code. Please Help

Question about the task

Resolved

So I came up with this code but I really got no idea what part is messing it up. Spent over a day with several breaks tryna crack it but can't.

1. Read 10 words from the keyboard and add them to a list of strings.
2. Determine whether the list is ordered by increasing string length.
3. If it is not, then display the index of the first element that violates this order.

Requirements:

Declare a string list variable and immediately initialize it.
Read 10 lines from the keyboard and add them to the list.
If the list is ordered by increasing string length, then you don't need to display anything.
If the list is not ordered by increasing string length, then display the index of the first element that violates this order.

package com.codegym.task.task07.task0718; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Checking the order */ public class Solution { public static void main(String[] args) throws IOException { ArrayList<String> list = new ArrayList<String>(); BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); for (int i = 0; i < 10; i++){ list.add(br.readLine()); } int ind = 0; String t1; String t2; for (int i = 1; i < 10; i++){ t1 = list.get(i - 1); t2 = list.get(i); if (t1.length() >= t2.length()) ind = list.indexOf(t2); break; } if (ind != 0) System.out.println(ind); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Ivan Robert Vecerina

Level 8 , Warrington, United Kingdom

18 August 2019, 19:33

Fixed it, the issue was the missing accolades around the "if"

Hrishikesh Kalita

Level 8 , Guwahati, India

18 August 2019, 18:37

I think it is because of slight error in the logic. See, your code neglected the possibility to give output as '0' if the very first element violates the order. So, just try the following code. Changes made: 1. int ind = -1; 2. for (int i = 0; i < 9; i++){...} 3. ind = list.indexOf(t1);

{
	public static void main(String[] args) throws Exception {
		ArrayList<String> list = new ArrayList<String>();
        BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

        for (int i = 0; i < 10; i++){
            list.add(br.readLine());
        }

        int ind = -1;
        String t1;
        String t2;

        for (int i = 0; i < 9; i++){
            t1 = list.get(i);
            t2 = list.get(i+1);

            if (t1.length() >= t2.length())
                ind = list.indexOf(t1);
                break;
        }
        if (ind != -1)
            System.out.println(ind);
	}