last condition????

Question about the task

Under discussion

It works fine when I enter a positive number, but then there is an unwanted incrementation when the input is negative. How to satisfy the last condition? I even used the letters 'a' & 'b' as depicted in the question. Thanks in advance!

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static int even; public static int odd; public static void main(String[] args) throws IOException { BufferedReader x = new BufferedReader(new InputStreamReader(System.in)); String N = x.readLine(); int n = Integer.parseInt(N); int rem, a=0, b=0; if(n<0){ n = n*(-1); System.out.println(n); } for(int j=0; j<N.length(); j++){ rem = n%10; n = n/10; if(n%2==0){ even += 1; } else if(n==0){ even += 1; } else odd += 1; System.out.println(even+" "+odd); } a = even; b = odd; System.out.println("Even: "+a+" Odd: "+b); //write your code here } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Girish Patel

Level 8 , Hyderabad, India

30 September 2019, 20:37

you have made code complex. Just make code always simple and sort. You can use while loop instead of for loop. Because of to for loop you will have to count how many digits in the number. So don't waste your time just use while only.

public class Solution {
    public static int odd;
    public static int even;

    public static void main(String[] args) throws IOException {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

        int a= Integer.parseInt(reader.readLine());

        while (a >0) {

            if (a%2 == 0) {
                even ++;
            } else {
                odd ++;
            }
            a/=10;
        }
        System.out.println("Even: "+even+" Odd: "+odd);
    }
}

Dawid

Level 28

6 September 2019, 00:16

First of all, it doesn't pass the test through because your extra prints, but you probably know that. Second, flip those n = n/10 on the end of the loop because otherwise it will not work with single-digit numbers. You can then discard this section dedicated to n==0 cause n%2==0 will do. And fourthly, we are left with the question of these negative numbers. Probably even if immediately after you get n you could give something like if (n <= 0){ return;} and probably it would pass. And if not, you need to get the number of digits like this: int digits = 0; Double temp = n; while((temp/10)>=0.1) { digits++; temp = temp/10; } And of course then give digits in for loop instead of N.length()

hidden #10462592

Level 8

7 September 2019, 13:06

I appreciate your explanation but did not understand the snippet you shared, although I understood the concept... since it is a string, the '-' minus symbol is indexed as 0 and then it starts goes to next digit and so on. Can you explain it in simpler terms, please? thank you :) ...

Dawid

Level 28

7 September 2019, 17:14

1. First- the task of the program is to print the specified text:

System.out.println("Even: "+a+" Odd: "+b);

is correct. The rest of System.out.println methods in your code you should delete. 2. At the beginning of your for loop you have:

rem = n%10;
            n = n/10;

I don't know what rem is but this is unnecessary so delete it. Regarding a line of code:

n = n/10;

move it to the end of this for loop.

for(int j=0; j<N.length(); j++){


            if(n%2==0){
                even += 1;
                }
            else if(n==0){
                even += 1;
            }
            else{
                odd += 1;
}
          n = n/10;
}

Otherwise, if the user enters a one-digit number your program may not work properly. Because first off you divide it by ten and then check the conditions in that loop. 3. Checking if n is zero in this loop is unnecessary, but it can stay. Condition:

if(n%2==0){
                even += 1;
                }

takes into account the case when n is zero. 4. When it comes to negative numbers entred by user, I don't know if you have to include them in this task at all. In your place, I would throw this piece of code:

if(n<0){
            n = n*(-1);
            System.out.println(n);
        }

and instead gave a stand-alone function to calculate number of how many digits the user entered.

int digits = 0;
Double temp = n;
while((temp/10)>=0.1)
        {
            digits++;
            temp = temp/10;

        }

Of course, additionally change j<N.length in for loop to j<digits.

hidden #10462592

Level 8

12 September 2019, 13:41

I totally get it now. I was stuck at this small thing for so long , you're the best!! Thank you, beautifully done!