What is wrong with this logic?

Why don´t you try to use a for loop and an array with numbers to implement solution? Think about this: what if you had to compare 1000 numbers? It would be unfeasible to compare with ifs... Using an array would make more legible the solution also... Best regards

The main problem is too many queries, mine used 4 statements, which first compared a with b, c and d using >= operation, this covers all cases by printing a if it is the highest number/s and does not need to be compared again. Second was b with c and d, then third was c with d. Finally the else statement had to be to print d as this was the only option left. it looked like this: import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); int b = Integer.parseInt(reader.readLine()); int c = Integer.parseInt(reader.readLine()); int d = Integer.parseInt(reader.readLine()); if (a >= b && a >= c && a >= d) System.out.println(a); else if (b >= c && b >= d) System.out.println(b); else if (c >= d) System.out.println(c); else System.out.println(d); } }

When the code is co complicated - it is hard to debug. I suggest you simplify it by using the following Java built-in method:

Math.max(a, b);

Ternary operator make this task much more simple - read about it if never used it before. In some cases like when you have to do many if else statements, it can really shorten the code + reduces the pocibility for error: //I took 4 user inputs, and then: int max; max = a>b? a:b; max = max>c? max:c; max = max>d? max:d; System.out.println(max) ;

Try to compare 1.) a with b and c and then 1.1.) a with d : if a >= d, then max=a else max=d 2.) b with a and c 2.1.) b with d 3.) c with a and b 3.1.) c with d finish

Your Conditions are to long. Write like this "if (a>=b && a>=c && a>=d){ System.......(a); }" after this condition use "else if" Condition and this will give you the output in Short only.

Test your code with example 5,2,3,5