Right answer, but failed requirements.

Question about the task

Under discussion

So.. with a little help from @Heavy I got the program to run..but while I'm getting the correct output I'm faiing multiple requirements. Hmmm

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a= Integer.parseInt(reader.readLine()); int odd = 0 ; int even = 0; while (a >0) { if (a%2 == 0) { even ++; } else { odd ++; } a/=10; } System.out.println("Even: "+even+" Odd: "+odd); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Girish Patel

Level 8 , Hyderabad, India

30 September 2019, 20:08

Firstly don't remove instance variable public static int even; public static int odd; only use it in your code. Else code is good. You can see that code is in the image.

Wei Cui

Level 39 , Newark, United States

28 September 2019, 15:15

public static void main(String[] args) throws IOException { //write your code here BufferedReader r = new BufferedReader (new InputStreamReader (System.in)); String sNum = r.readLine(); int length = sNum.length(); int num = Integer.parseInt(sNum); while (length > 0) { if (num % 2 == 0){ even++; } else { odd++; } num /= 10; length -= 1; } System.out.println("Even: " + even + " Odd: " + odd); }

Oregano

Level 24 , Warsaw, Poland

24 September 2019, 20:13

useful

The logic seems to be fine (very similar to my solution and it passed). I noticed that you removed counters from class Solution and moved them to main method. I'm always very cautious when it comes to changing such things, it can affect validation :)

Adnan Razzaq

Level 15 , Bamberg, Germany

22 September 2019, 12:24

logic is not correct.

Heavy

Level 41

19 September 2019, 17:10

I guess it could be something with 0. If i write a zero only, it doesn't count it anywhere (I don't know mathematically 0 is even or odd, it depends on the kind of math, but it can be divisible by 2 without remainder, so from this, I guess it should be even). If I try like 1201001 it counts correctly Even: 4 Odd: 3 I actually checked my solution for this, I did something very different, I read a String from the keyboard, and after that I looped through every character (parsed as int) and checked individually the numbers. The only different behavior of the output is the single zero, other numbers got the same result as your code.