nothing wrong ,i think so

Question about the task

Cat relations

Java Syntax, Level 6, Lesson 11

Under discussion

Why it cant fit the conditions? Help please

Task: Each cat has a name and a mother.
Create a class that describes this situation.
Create two objects: a daughter cat and a mother.
Display them on the screen.

New task: Each cat has a name, a father, and a mother.
Edit Cat so that it reflects these relationships.
Create 6 objects: grandfather (the father's father), grandmother (the mother's mother), father, mother, son, daughter.
Display them all in the following order: grandfather, grandmother, father, mother, son, daughter.

Example input:
Grandfather Tiger Grandmother Puss Father Oscar Mother Missy Son Simba Daughter Coco

Example output:
The cat's name is Grandfather Tiger, no mother, no father The cat's name is Grandmother Puss, no mother, no father The cat's name is Father Oscar, no mother, Grandfather Tiger is the father The cat's name is Mother Missy, Grandmother Puss is the mother, no father The cat's name is Son Simba, Mother Missy is the mother, Father Oscar is the father The cat's name is Daughter Coco, Mother Missy is the mother, Father Oscar is the father

Requirements:

The program should read in the names of 6 cats in the specified order.
The main method should create 6 Cat objects.
The program should display 6 lines with information about the cats.
The line about the grandfather (first line) must match the conditions.
The line about the grandmother (second line) must match the conditions.
The line about the father (third line) must match the conditions.
The line about the mother (fourth line) must match the conditions.
The line about the son (fifth line) must match the conditions.
The line about the daughter (sixth line) must match the conditions.

package com.codegym.task.task06.task0621; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; /* Cat relations */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String grandfatherName = reader.readLine(); Cat grandfather = new Cat(grandfatherName); String grandmontherName = reader.readLine(); Cat grandmonther = new Cat(grandmontherName); String fatherName = reader.readLine(); Cat father = new Cat(fatherName,grandfather); String montherName = reader.readLine(); Cat monther = new Cat(montherName,grandmonther); String sonName = reader.readLine(); Cat son = new Cat(sonName,father,monther); String daughterName = reader.readLine(); Cat daughter = new Cat(daughterName,father,monther); System.out.println(grandfather.toString()); System.out.println(grandmonther.toString()); System.out.println(father.toString()); System.out.println(monther.toString()); System.out.println(son.toString()); System.out.println(daughter.toString()); // String daughterName = reader.readLine(); // Cat catDaughter = new Cat(daughterName, catMother); // System.out.println(catMother); // System.out.println(catDaughter); } public static class Cat { private String name; private Cat parent1; private Cat parent2; private Cat father; private Cat monther; Cat(String name) { this.name = name; } Cat(String name, Cat parent1) { this.name = name; this.parent1 = parent1; } // Cat(String name, Cat parent2) { // this.name = name; // this.parent2 = parent2; // } Cat(String name,Cat father,Cat monther){ this.name =name; this.father=father; this.monther=monther; } // Cat(String name, Cat father){ // this.name = name; // this.father = father; // } @Override public String toString() { if (parent1 == null&&parent2 ==null&&father==null&&monther==null) return "The cat's name is " + name + ", no mother, no father "; else if(parent1!=null&&parent1.name.equals("Grandfather Tiger")) return "The cat's name is " + name + ", no mother, " + parent1.name + " is the father"; else if(parent1!=null&&parent1.name.equals("Grandmother Puss")) return "The cat's name is " + name+ ", "+ parent1.name + " is the mother, no father"; else //(father != null && monther !=null) return "The cat's name is " + name + ", "+monther.name+" is the mother, "+father.name+" is the father"; } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Patryk

Level 24 , Warsaw, Poland

3 October 2019, 22:32

You can handle with this by passing null to constructor (for example, when cat doesn't have father) or by creating two constructors: Cat(String name, Cat mother) {this.name = name; this.mother = mother} Cat(Cat father, String name) {this.name = name; this.father = father) Of course you need to be carefull when you're passing arguments In toString method you don't need equals, just comparision to null and also while printing out you don't need to use method toString on objects, java knows what's going on

Alexandru Ovcinicov

Level 15 , London, United Kingdom

30 September 2019, 18:09

public static class Cat{ String name; private Cat father; private Cat mother; Constructors... for : 1) just a name => for grandparents 2) name + mother => for mother or father 3) name + father => for mother or father 4) name + both mother and father => for kids } String grandfatherName = reader.readLine(); Cat grandfather = new Cat(grandfatherName); String grandmontherName = reader.readLine(); Cat grandmonther = new Cat(grandmontherName); String fatherName = reader.readLine(); Cat father = new Cat(fatherName,grandfather); String montherName = reader.readLine(); Cat monther = new Cat(montherName,grandmonther); String sonName = reader.readLine(); Cat son = new Cat(sonName,father,monther); String daughterName = reader.readLine(); Cat daughter = new Cat(daughterName,father,monther); will try with advicing you my "a" piece of pseudoCode as a hint and your code for you: Every created new Cat() object should have as a field only a name and two other Cat objects... + some advices on Constructors. What you think ?