My two tasks are not validated. But unable to find the cause

Question about the task

Archived

My two tasks are not getting validated and I am unable to find the cause of failure. Could anyone please help? I am displaying a number on screen and my program displays the maximum of all.

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); double maximum = 0; //write your code here while (true) { String s = reader.readLine(); if (s.equals("exit")) break; double max = Double.parseDouble(s); if (max > maximum) maximum = max; else continue; } System.out.println("Maximum = " + maximum ); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Anonymous #10011987

Level 16

12 October 2019, 08:07

I think you should remove the extra output prompt you are providing "Maximum = ". It's not needed. That's why I think it's showing error on 2nd and last requirements. You should only display the maximum number nothing else. Check by resubmitting after removing the extra prompt, "Maximum = ".

Guadalupe Gagnon

Level 37 , Tampa, United States

6 October 2019, 15:45

Step 1: Read a number, saved to variable 'N' Step 2: create a loop to read 'N' more numbers Step 3: display the maximum of the 'N' entered numbers For example: S1: enter the number 5, now N = 5 S2: create a loop that will loop N times, N = 5 so loop will loop 5 times reading a number each cycle S2(loop 1) enter '6' S2(loop 2) enter '3' S2(loop 3) enter '7' S2(loop 4) enter '5' S2(loop 5) enter '2' S3: Outputs the highest of the 5 entered numbers in the loop. Output is: 7

Raj Mishra Java Developer at Sopra banking softwa

10 October 2019, 09:17

So what wrong I am doing in my code. Could you please identify the mistake ?

Guadalupe Gagnon

Level 37 , Tampa, United States

10 October 2019, 13:20

I already did. You dont read N You dont loop N times You dont find the max of N numbers.

Anonymous #10011987

Level 16

12 October 2019, 08:11

Yes, you are right, the code must read a number N( > 0) at first before it enters the loop. So it must be like this:

int N = Integer.parseInt(br.readLine());
then you could run your loop like,
for(int i = 1; i <= N; i++) {
     .................Loop body
}