I can't finish my task with the fourth requirement. I don't know why, what problem in my code??

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Under discussion

Any helps would be appreciated

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader read = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> list = new ArrayList<>(); for(int i=0;i<10;i++){ list.add(read.readLine()); } // for the longest string int longest = list.get(0).length(); for(int i=1;i<10;i++){ if(longest < list.get(i).length()){ longest = list.get(i).length(); } } // for the shortest string int shortest = list.get(0).length(); for(int i=1;i<10;i++){ if(shortest > list.get(i).length()){ shortest = list.get(i).length(); } } String s1=null,s2=null; for(int i=0;i<10;i++){ if(longest == list.get(i).length()){ s1 = list.get(i); } } for(int i=0;i<10;i++){ if(shortest == list.get(i).length()){ s2 = list.get(i); break; } } if(list.indexOf(s1) < list.indexOf(s2)){ System.out.println(s1); }else{ System.out.println(s2); } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

8 October 2019, 17:18

useful

you need a break in the loop between 41-45. Right now it gets the last word in the list with the largest length. Some programming tips though: #1 you can combine the loops at lines 25-30 and 33-38 into one:

for(int i=1;i<10;i++){
   int temp = list.get(i).length();
   if(shortest > temp)
      shortest = temp;
   if(longest < temp)
      longest = temp;
   }
}

#2 you now know the lengths of the shortest and longest, you dont need to then find the shortest and longest string. When the first word that matches the shortest or longest occurs, output that. This means you can get rid of lines 40-58 and replace with this:

for(int i=0;i<10;i++){
   int temp = list.get(i).length();
   if(shortest == temp || longest == temp){
      System.out.println(list.get(i));
      break;
   }
}

Gia Huy Kaiser

Level 15 , Berlin, Germany

8 October 2019, 18:18

many tkssssssssss