What is wrong with my code? The last two requirements are not satisfied. Thanks a lot.

Question about the task

Archived

package com.codegym.task.task07.task0708; //import java.io.BufferedReader; //import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; import java.util.Scanner; /* Longest string */ public class Solution { private static List<String> strings = new ArrayList<String>();; private static int longest; public static void main(String[] args) throws Exception { Scanner sc = new Scanner(System.in); for (int i = 0; i < 5; i++) { String s = sc.nextLine(); strings.add(s); } longest = strings.get(0).length(); for(int i = 0; i < 5; i++) { int element = strings.get(i).length(); if(longest < element) longest = element; } for(int i = 0; i < 5; i++) { if(longest == strings.get(i).length()) System.out.println(strings.get(i)); } } }

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

1 November 2019, 20:13

The starting code for this task is:

public class Solution {
    private static List<String> strings;

    public static void main(String[] args) throws Exception {
        //write your code here
    }
}

It looks like you added code where you were not supposed to. Fix your code so that it only has code where it says code should be.

Cristian

Level 16 , Bucharest, Romania

1 November 2019, 20:28

I hope I see your point. Why the last two requirements are not satisfied? Where are my mistakes? Thank you very much! package com.codegym.task.task07.task0708; //import java.io.BufferedReader; //import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; import java.util.Scanner; /* Longest string */ public class Solution { private static List<String> strings = new ArrayList<String>(); public static void main(String[] args) throws Exception { Scanner sc = new Scanner(System.in); for (int i = 0; i < 5; i++) { String s = sc.nextLine(); strings.add(s); } int longest = strings.get(0).length(); for(int i = 0; i < 5; i++) { int element = strings.get(i).length(); if(longest < element) longest = element; } for(int i = 0; i < 5; i++) { if(longest == strings.get(i).length()) System.out.println(strings.get(i)); } } }

Guadalupe Gagnon

Level 37 , Tampa, United States

1 November 2019, 20:45

public class Solution { private static List<String> strings = new ArrayList<String>(); The reason you are failing is because this bit of code (in bold) is outside the parameters of the task requirements. This isn't so much a mistake, in the real world it is perfectly acceptable. You can even use static variables like you did in the original code, though you should stay away from them unless they are going to be used in multiple methods. A lot of these tasks are tested in such a way that they don't really allow a lot of wiggle room. It gets frustrating in later tasks when some silly little thing like this is failing a task with a couple hundred lines of code.

Guadalupe Gagnon

Level 37 , Tampa, United States

1 November 2019, 20:47

public class Solution { private static List<String> strings; public static void main(String[] args) throws Exception { strings = new ArrayList<String>();

Cristian

Level 16 , Bucharest, Romania

2 November 2019, 19:05

It works, Gagnon! I'm happy! Thank you so much!