What is wrong with this code?

Question about the task

Minimum of three numbers

Java Syntax, Level 2, Lesson 8

Under discussion

It prints: 1 -3 3 5 Shouldn't that be correct?

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static int min(int a, int b, int c) { //write your code here int min; if (a <= b && b <= c) min = a; else if (b <= a && a <= c) min = b; else min = c; return min; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Ndatta Fall

Level 6 , Bowie, United States

29 December 2019, 16:06

you are missing the if and else brackets

Guadalupe Gagnon

Level 37 , Tampa, United States

5 November 2019, 19:11

Have you tried all cases yet? I work my way along every single scenario when testing code. Try entering these values (can copy + paste) into main:

System.out.println("min(1, 2, 3) = " + min(1, 2, 3)); // a < b : a < c : b < c
System.out.println("min(1, 3, 2) = " + min(1, 3, 2)); // a < b : a < c : b > c
System.out.println("min(2, 1, 3) = " + min(2, 1, 3)); // a > b : a < c : b < c
System.out.println("min(2, 3, 1) = " + min(2, 3, 1)); // a < b : a > c : b > c
System.out.println("min(3, 1, 2) = " + min(3, 1, 2)); // a > b : a > c : b < c
System.out.println("min(3, 2, 1) = " + min(3, 2, 1)); // a > b : a > c : b > c
System.out.println("min(1, 1, 2) = " + min(1, 1, 2)); // a == b : a < c : b < c
System.out.println("min(1, 2, 1) = " + min(1, 2, 1)); // a < b : a == c : b > c
System.out.println("min(2, 1, 1) = " + min(2, 1, 1)); // a > b : a > c : b == c
System.out.println("min(2, 2, 1) = " + min(2, 2, 1)); // a == b : a > c : b > c
System.out.println("min(2, 1, 2) = " + min(2, 1, 2)); // a > b : a == c : b < c
System.out.println("min(1, 2, 2) = " + min(1, 2, 2)); // a < b : a < c : b == C
System.out.println("min(1, 1, 1) = " + min(1, 1, 1)); // a == b : a == c : b == c

That should cover all scenarios. Every single one of these should output 1 as the min, some of them do not.