What is wring with my code

Question about the task

Even and odd digits

Java Syntax, Level 6, Lesson 5

Under discussion

Hi, can someone help me with this one ? thx

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static int even; public static int odd; public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); String str = String.valueOf(a); int tlength = str.length(); for(int i = 0; i < tlength; i++) { int flag = Integer.valueOf(str.substring(i,i+1)); if(flag % 2 == 0) { even++; }else{ odd++; } System.out.println("Even:" + even + " " + "Odd:" + odd); } //write your code here } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

8 November 2019, 03:43

line 28 is inside you loop. You should move it outside the loop. You should practice indenting your code according to best practices, it makes it easier to read and spot things like this:

public class Solution {

    public static int even;
    public static int odd;

    public static void main(String[] args) throws IOException {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int a = Integer.parseInt(reader.readLine());
        String str = String.valueOf(a);
        int tlength = str.length();
        for(int i = 0; i < tlength; i++) {
            int flag = Integer.valueOf(str.substring(i,i+1));
            if(flag % 2 == 0) {
                even++;
            }else{
                odd++;
            }
            System.out.println("Even:" + even + " " + "Odd:" + odd);
        }
    }
}

Level 20 , Toronto, Canada

9 November 2019, 06:13

Thank you for explian this to me.

Guadalupe Gagnon

Level 37 , Tampa, United States

9 November 2019, 16:35

Do you have intelliJ yet? One of the cool features of it is that it auto formats from you. Even if you start deleting things and typing in additional, non-formatted, code. If you find your code isn't formatted properly, just go to the very bottom of your code, delete the curly bracket, type it back in, and intelliJ will format the entire class properly. Very helpful feature.

Level 20 , Toronto, Canada

26 November 2019, 05:21

Sorry to reply you this late. No, I don't really have that on my desktop. I just think it is too early to install this. Coz there is a lot of questions that I couldn't do it by myself. Maybe I will install IntelliJ or EClipse after I feel I have confidence on my coding skill. Thank you for your advise.

Guadalupe Gagnon

Level 37 , Tampa, United States

26 November 2019, 14:15

IntelliJ will make troubleshooting and solving these 10 times easier. By level 3 you should have it and you are just bogging down your learning by not doing so.

Level 20 , Toronto, Canada

26 November 2019, 21:03

Thanks.I will start to do things at IntelliJ.