It says "The item with the updated data should be on the same line in the file." But it is, isn't it?

Question about the task

Under discussion

Hello everybody. I don't catch this situtation. My code isn't verified because of the third condition and the recommendation is "The item with the updated data should be on the same line in the file." But my test show exactly this requirement. Can you help me pointing out my mistake? I'd be glad about any help and thx.

CrUD for a table inside a file
Read a file name for CrUD operations from the console

The program runs with one of the following sets of arguments:
-u id productName price quantity
-d id

Argument values:
where id is 8 characters
productName is 30 characters
price is 8 characters
quantity is 4 characters
-u updates the data for the product with the specified id
-d performs the physical deletion of the product with the specified id (all data related to the passed id)

The file data is stored in the following order (without separating spaces):
id productName price quantity
Each data field is padded with spaces up to its length

Example:
19847 Swim trunks, blue 159.00 12 198479 Swim trunks, black with printe173.00 17 19847983Snowboard jacket with reflecti10173.991234

Requirements:

The program should read a file name for CrUD operations from the console.
When you run the program without arguments, the product list must remain unchanged.
When the program is started with the arguments "-u id productName price quantity", the product information in the file should be updated.
When the program is started with the arguments "-d id", the line for the product with the specified id should be removed from the file.
The file streams must be closed.

package com.codegym.task.task18.task1828; /* Prices 2 */ import java.io.*; import java.util.ArrayList; import java.util.HashMap; import java.util.Map; public class Solution { public static void main(String[] args) throws Exception { //ArrayList<Product> productList = new ArrayList<>(); HashMap<Integer, Product> productList = new HashMap<>(); BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); String fileName = br.readLine(); br.close(); FileReader fileReader = new FileReader(fileName); BufferedReader bufferFile = new BufferedReader(fileReader); while (bufferFile.ready()) { String strProduct = bufferFile.readLine(); //System.out.println(strProduct); Product prod = new Product(strProduct); productList.put(prod.id, prod); } if((args.length>0) &&(args[0].equals("-d"))){ int idToDelete = Integer.parseInt(args[1]); productList.remove(idToDelete); } int idToUpdate = 0; Product updateProduct = null; if((args.length>0) &&(args[0].equals("-u"))){ idToUpdate = Integer.parseInt(args[1]); String strUpdate = ""; strUpdate = fillWithSpaces(strUpdate, String.valueOf(idToUpdate), 8); strUpdate = fillWithSpaces(strUpdate, args[2], 30); strUpdate = fillWithSpaces(strUpdate, args[3], 8); strUpdate = fillWithSpaces(strUpdate, args[4], 4); updateProduct = new Product(strUpdate); //productList.replace(idToUpdate, productList.get(idToUpdate), updateProduct); } FileWriter fileWriter = new FileWriter(fileName); BufferedWriter bufferWriter = new BufferedWriter(fileWriter); int maxId = 0; //for (Product prod : productList) { //prod = null; for(Map.Entry<Integer, Product> entry : productList.entrySet()) { Product prod = entry.getValue(); if (prod.id == idToUpdate) { prod = updateProduct; } bufferWriter.write(prod.toString()+"\n"); if (prod.id>maxId) maxId = prod.id; System.out.println(prod.toString()); } if((args.length>0) &&(args[0].equals("-c"))){ String newProduct = ""; newProduct = fillWithSpaces(newProduct, String.valueOf(maxId+1), 4); newProduct = fillWithSpaces(newProduct, args[1], 30); newProduct = fillWithSpaces(newProduct, args[2], 8); newProduct = fillWithSpaces(newProduct, args[3], 4); bufferWriter.write(newProduct); } bufferFile.close(); bufferWriter.close(); } public static String fillWithSpaces(String newLine, String data, int numberOfChars) { newLine += data; for (int i=data.length(); i<numberOfChars; i++) { newLine += " "; } return newLine; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Wei Cui

Level 39 , Newark, United States

28 March 2020, 21:48

public static void deleteLine(String file, String[] args) throws IOException {
        String id = args[1];
        BufferedReader br = new BufferedReader(new FileReader(file));
        ArrayList<String> lineList = new ArrayList<>();
        while(br.ready()) {
            String line = br.readLine();
            if (line.substring(0, 8).trim().equals(id)) {
                continue;
            } else
                lineList.add(line);
        }
        br.close();

        FileWriter fw = new FileWriter(file);
        for (String s : lineList) {
            fw.write(s + "\r\n");
        }

        fw.close();
    }

Wei Cui

Level 39 , Newark, United States

28 March 2020, 21:47

public static void updateFile(String file, String[] args) throws IOException {
        String id = args[1];
        String newProductName = args[2];
        String newPrice = args[3];
        String newQuantity = args[4];
        String undateLine = String.format("%-8s%-30s%-8s%-4s", id, newProductName, newPrice, newQuantity);

        BufferedReader br = new BufferedReader(new FileReader(file));
        ArrayList<String> lineList = new ArrayList<>();
        while(br.ready()) {
            String line = br.readLine();
            if(line.substring(0, 8).trim().equals(id)) {
                line = undateLine;
            }
            lineList.add(line);
        }
        br.close();

        FileWriter fw = new FileWriter(file);
        for(String s : lineList)
            fw.write(s +"\r\n");

        fw.close();

    }

Wei Cui

Level 39 , Newark, United States

28 March 2020, 21:47

public static void main(String[] args) throws IOException {
        //read file name
        BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in));
        String file = "";
        try {
            file = bufferedReader.readLine();
            bufferedReader.close();
        } catch (IOException e) {
            e.printStackTrace();
        }

        if (args.length > 0) {
            switch (args[0]) {
                case "-u":
                    updateFile(file, args);
                    break;
                case "-d":
                    deleteLine(file, args);
            }
        }
//        String[] arr = new String[] {"19847983", "apple", "2354.2", "222"};
//        String[] arr1 = new String[] {"198479"};
        updateFile(file, args);
        deleteLine(file, args);
    }