help please

Level 25 , Bhopal, India

29 September 2018, 19:20

1. In line 22, why you are using println ? It states that if the list is in increasing order, you don't have to display anything. Not even newline. 2.

else if(list.get(i).length()>list.get(j).length()){
                    System.out.println(list.indexOf(list.get(i)));
                }

In the above code (line 24), you are checking for unorder and then displaying the index. That's fine but you are doing this for every string that violates the order. You just have to display the index of first string that violates the order and the break out of all the loops and end program.

Level 9 , Mohali, India

29 September 2018, 20:29

got it thanks bro...

Level 9 , Mohali, India

30 September 2018, 19:47

bro break is not working...how can i stop after first failure?

Level 25 , Bhopal, India

30 September 2018, 20:09

Initialize an int to 0. Then in block which checks for failure, increment it by 1. Then after that you can check if (int >0) break. Think about it. You have two loops to break from. Two break statements will be needed.

Level 9 , Mohali, India

1 October 2018, 06:26

public class Solution { public static void main(String[] args) throws IOException { BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); int num=0; ArrayList<String> list = new ArrayList<String>(); for(int i=0; i<10; i++){ list.add(br.readLine()); } for(int i=0; i<list.size(); i++){ if(list.get(i).length()<list.get(i+1).length()){ } else if(list.get(i).length()>list.get(i+1).length()){ System.out.println(list.indexOf(list.get(i))); num+=1; } if(num>0){ break; } } } }

Level 9 , Mohali, India

1 October 2018, 06:26

i changed my code to this its working properly but not fulfilling last condition

Level 25 , Bhopal, India

1 October 2018, 06:42

In else if block, you are displaying wrong index. it should be as below -

System.out.println(list.indexOf(list.get(i+1)));

You have to display the index of number that violates the order. If first number's length is greater than 2nd number, then 2nd number violates the order and not first. If you are using a single for loop, you don't have to use num to break out of loop. That idea was for to break out of two loops. In this you can simply do this -

else if(list.get(i).length()>list.get(i+1).length()){
                   System.out.println(list.indexOf(list.get(i+1)));
                   break;
                   }

Infact it you for loop block can further be shortened as below -

for(int i=0; i<list.size(); i++){

               if(list.get(i).length()>list.get(i+1).length()){
                   System.out.println(list.indexOf(list.get(i+1)));
                   break;

               }
                }

You only have to check if next string length is greater or smaller. If smaller then execute and break otherwise do nothing. No need of using an empty if block.

Level 9 , Mohali, India

1 October 2018, 06:54

thanks a lot bro

Level 25 , Bhopal, India

1 October 2018, 06:56

Mark it as resolved if verified.

Level 9 , Mohali, India

1 October 2018, 06:59

done

Level 16 , Lahore, Pakistan

7 October 2018, 07:47

what actually question mean...??? i didn't understand

Level 16 , Lahore, Pakistan

7 October 2018, 07:50

i think he said that max maxxx max the result will be 2; and i made program for this =}

Level 16 , Lahore, Pakistan

7 October 2018, 07:50

but not fulfuling last condition

Level 16 , Lahore, Pakistan

7 October 2018, 07:52

for (int i = 0; i < 10; i++)
        {
            if (i == 0) {

                max = list.get(i).length();
            } else if (list.get(i).length() > max) {

                continue;
            }
                else {
                System.out.print(i);
                break;
            }


            }
        }

Level 16 , Lahore, Pakistan

7 October 2018, 07:52

help me understanding the question

Level 25 , Bhopal, India

7 October 2018, 08:00

Incase of max maxxx max result will be 3. Index starts with 1. Internal array numbering starts with 0. Use internal array numbering when you want to access or put elements in array. You can use indexOf() function of arraylist to display index or just return i+1. It should work.