What part of my code is not scanning that would show that the maximum number displayed is the maximum number entered?

Question about the task

Task about algorithms

Java Syntax, Level 5, Lesson 12

Under discussion

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; import java.util.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); //write your code here String input; input = reader.readLine(); int N; int maximum = 0; ArrayList<Integer> numArray = new ArrayList<Integer>(); while(input != null) { N = Integer.parseInt(input); numArray.add(N); if(N > maximum) { maximum = N; } input = reader.readLine(); } Collections.sort(numArray); Collections.reverse(numArray); for(int i = 0; i < numArray.size(); i++) { if(numArray.get(i) > maximum) { maximum = numArray.get(i); } } if(maximum > 0) { System.out.println(maximum); } // nextNum = Integer.parseInt(reader.readLine()); // int[] numArray = new int[0]; // ArrayList<Integer> numArray = new ArrayList<Integer>(); // // int spot = 0; // while(input != null) { // nextNum = Integer.parseInt(input); // if(nextNum > 0) { // numArray.add(nextNum); // } // // numArray[spot] = nextNum; // // spot++; // Collections.sort(numArray); // Collections.reverse(numArray); // input = reader.readLine(); // } // for(int i = 0; i < numArray.size(); i++) { // if(numArray.get(i) > maximum) { // maximum = numArray.get(i); // } // } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

manpreet singh

Level 6 , Ottawa, Canada

3 May 2020, 06:21

it can be done without using Min_value. https://codegym.cc/help/9251

Kamil

Level 31 , Near Warsaw, Poland

2 January 2020, 22:34

Alrighty, my man. I see, you didn't get the requirements at all, it's fine, they can be confusing sometimes especially the higher you get. Write code to : - read a number N which you have to check if it bigger than 0, neither equal or less - then how much this number is, then that's how many times you gotta read some numbers from the console - add them anywhere you want, create Integer which value will be first index of list, array.. anything you want - and just loop through and compare, and print it out

Kamil

Level 31 , Near Warsaw, Poland

2 January 2020, 22:36

Ohh and one more advice, read about KISS methodology, you are able to shorten this code and clean it up a bit. Good practice makes perfect.

Seb

Level 41 , Crefeld, Germany

29 December 2019, 21:08

I would suggest you reread the specifications. You should first read in a number, e.g. N. Then read in as many numbers as the value of N. For example - let's say N is 3. Then you'll read in three more values and you'll check which of those three values entered is the maximum. It's also a good idea not to initialize the maximum to 0, since you may read in only negative numbers and would then not get the correct result. Simply initialize the maximum to the first number you read in after N, and then check whether bigger numbers follow. Cheers