I'm at a loss, need another pair of eyes

Question about the task

Under discussion

I've been over and over this, I'm sure there is something simple I am missing, but I can't figure out what it is, it seems like it should work... also why does the validator say I haven't closed my FileReader Streams?

Read 2 file names from the console: file1 and file2.
Both files contain text, but file2 is an updated version of file1. Some of the lines are still the same.
You need to create a merged version of the lines by writing them to the lines list.
The ADDED and REMOVED labels can't be used consecutively—they must always separated by the SAME label.
The example includes empty lines for clarity.
Neither the original file nor the updated file have empty lines!

Example 1:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 REMOVED line4 line5 line5 SAME line5 line0 ADDED line0 line1 line1 SAME line1 line2 REMOVED line2 line3 line3 SAME line3 line4 ADDED line4 line5 line5 SAME line5 line0 REMOVED line0

Example 2:
original updated merged file1: file2: Result: (lines) line1 line1 SAME line1 line0 ADDED line0

In the example, empty lines mean that the line is not in the specified file.

Requirements:

The Solution class must contain a LineItem class.
The Solution class must have an enum called Type.
The Solution class must have a public static List<LineItem> field called lines that is initialized immediately.
In the main(String[] args) method, the program must read file names from the console (use BufferedReader).
In the main(String[] args) method, the BufferedReader used for reading input from the console must be closed after use.
The program must read the contents of the first and second file (use FileReader).
The file input streams (FileReader) must be closed.
The lines list should contain the merged version of the lines from the files. Each line should start with the label ADDED, REMOVED, or SAME, depending on the action taken.

package com.codegym.task.task19.task1916; import javax.sound.sampled.Line; import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.LinkedHashMap; import java.util.List; /* Tracking changes */ public class Solution { public static List<LineItem> lines = new ArrayList<>(); public static void main(String[] args) throws IOException { BufferedReader fileNamesBufferedReader = new BufferedReader(new InputStreamReader(System.in)); String fileName1 = fileNamesBufferedReader.readLine(); String fileName2 = fileNamesBufferedReader.readLine(); fileNamesBufferedReader.close(); FileReader fileReader1 = new FileReader(fileName1); FileReader fileReader2 = new FileReader(fileName2); BufferedReader bufferForFileReader1 = new BufferedReader(fileReader1); BufferedReader bufferForFileReader2 = new BufferedReader(fileReader2); //Add all the Integers from the end of each line in file1 to file1ArrayList ArrayList <Integer> file1ArrayList = new ArrayList<>(); String buff1Line = bufferForFileReader1.readLine(); while(buff1Line != null){ String line = (buff1Line.trim()); String[] lineNumSplit = line.split("line"); int lineNum = Integer.parseInt(lineNumSplit[1]); file1ArrayList.add(lineNum); buff1Line = bufferForFileReader1.readLine(); } //Add all the Integers from the end of each line in file2 to file2ArrayList ArrayList <Integer> file2ArrayList = new ArrayList<>(); String buff2Line = bufferForFileReader2.readLine(); while(buff2Line != null){ String line = (buff2Line.trim()); String[] lineNumSplit = line.split("line"); int lineNum = Integer.parseInt(lineNumSplit[1]); file2ArrayList.add(lineNum); buff2Line = bufferForFileReader2.readLine(); } fileReader1.close(); fileReader2.close(); bufferForFileReader1.close(); bufferForFileReader2.close(); //TODO compare the two ArrayLists, add the appropriate line items to the lines arrayList for(int j = 0; j < file1ArrayList.size();){ //If the line number of element is equal to the line item number in file2Array, add the line item as type same //If the line number of element is smaller than the line item number in file2Array, add the line item as type removed and don't iterate yet //If the line number of element is bigger than the line item number in file2Array, add the line item as type added and don't iterate yet for(int i = 0; i < file2ArrayList.size();) if((file1ArrayList.get(j)).equals(file2ArrayList.get(i))){ LineItem lineItem = new LineItem(Type.SAME,"line"+(file1ArrayList.get(j)).toString()); lines.add(lineItem); i++; j++; } else if((file1ArrayList.get(j)) < (file1ArrayList.get(i))){ LineItem lineItem = new LineItem(Type.REMOVED,"line"+file1ArrayList.get(j).toString()); lines.add(lineItem); j++; } else if((file1ArrayList.get(j)) > (file2ArrayList.get(i))){ LineItem lineItem = new LineItem(Type.ADDED,"line"+file2ArrayList.get(i).toString()); lines.add(lineItem); i++; } } System.out.println("test"+lines.get(0)); for (LineItem element: lines) { System.out.println(element); } } public static enum Type { ADDED, // New line added REMOVED, // Line deleted SAME // No change } public static class LineItem { public Type type; public String line; public LineItem(Type type, String line) { this.type = type; this.line = line; } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Yiheng Niu

Level 26 , Beijing, China

6 March 2020, 10:19

You should not add Integers. "line1" could be "aaaa" or anything else. So treat the line as one string. All you need to do is to compare lines from file1 to file2. I'm trying to put my idea under the "discuss" column. You can go there and check it out. As for the FileReader Streams, I recommend this:

BufferedReader reader1 = new BufferedReader(new FileReader(fileName1));
...  //read operations
reader.close();

It's not error-prone.

Premachandran

Level 35 , Ernakulam, India

8 February 2020, 12:51

try closing each reader as soon as its use is over. your program compiles but the arrays are out of bounds line 76 and 77 increments i and j simultaneously.which causes this error. The files you read may not contain a string "line", (in your code line 52)., which I could not understand as the usage is wrong. Split() is used to split a string using a character or characters. Create 3 string arraylists. Add each line from file1 to arraylist-1 including null lines. Add each line from file2 to arraylist-2 including null lines. Compare these arraylists line by line using index and write the result to the arraylist-3 and put out the result from this arraylist.