Can't pass the validation of the mergeTiles method!

Question about the task

2048 (part 5)

Java Multithreading, Level 10, Lesson 15

Resolved

I've tested the method with various cases and can give the expected results, but just can't pass the validator. Any one can help?

The main actions that we need to enable are movements left, right, up and down.
If you've already played 2048, then you know that when you move in a direction, tiles with values move to empty tiles, and tiles with the same value combine.

As a basic scenario, let's consider movement to the left and think about what happens when we want to do this action.

For each row or column, two things actually happen:
a) Consolidate the tiles so that all the empty tiles are on the right, i.e. the row {4, 2, 0, 4} becomes {4, 2, 4, 0}
b) Merge tiles with the same value, i.e. the row {4, 4, 2, 0} becomes {8, 2, 0, 0}.
Note that the row {4, 4, 4, 4} will become {8, 8, 0, 0}, and {4, 4, 4, 0} becomes {8, 4, 0 , 0}.

Create consolidateTiles(Tile[] tiles) and mergeTiles(Tile[] tiles) methods that implement steps a) and b) respectively. We will use them only inside the Model class, so give them the narrowest possible access.

Also, add int score and int maxTile fields, which should store the current score and the highest tile weight on the game board. The score increases after each merger. For example, if the current score is 20 and the row {4, 4, 4, 0} is merged, then the score should increase by 8. The access level for these fields should be wider than private.
The easiest thing to do is to update these fields in the mergeTiles method, for example:
1) If the tile merger condition is satisfied, check whether the new value is greater than the maximum value and, if necessary, change the value of the maxTile field.
2) Increase the value of the score field by the amount of the tile weight generated by the merger.

P.S. When we implement the movement methods, tiles will always be consolidated before they are merged, so you can assume that the mergeTiles method will always be passed an array of tiles that does not have empty tiles in the middle.

Requirements:

The mergeTiles method must be implemented in accordance with the task conditions.
The consolidateTiles method must be implemented in accordance with the task conditions.
The consolidateTiles method must be private.
The mergeTiles method must be private.
The mergeTiles method should correctly update the value of the score field.
The mergeTiles method should correctly update the value of the maxTile field.
The score and maxTile fields must be initialized to zero when a new model is created.

package com.codegym.task.task35.task3513; import java.util.ArrayList; import java.util.List; public class Main { public static void main(String[] args) { int[] tiles = {4, 4, 4, 0}; mergeTiles(tiles); for (int i : tiles) { System.out.print(i + ", "); } } private static void consolidateTiles(int[] tiles) { List<Integer> temp = new ArrayList<>(); for (int i = 0; i < tiles.length; i++) { if (tiles[i] != 0) temp.add(tiles[i]); } for (int j = 0; j < temp.size(); j++) { tiles[j] = temp.get(j); } for (int j = temp.size(); j < tiles.length; j++) { tiles[j] = 0; } } private static void mergeTiles(int[] tiles) { int n = tiles.length; for (int i = 0; i < n - 1; i++) { if (tiles[i] == tiles[i+1]) { int newValue = tiles[i] * 2; tiles[i] = newValue; for (int j = i + 1; j < n - 1; j++) { tiles[j] = tiles[j+1]; } tiles[n-1] = 0; } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

23 January 2020, 16:26

public class Solution {
    public static void main(String[] args) throws IOException {
        mergeTiles(new int[]{2,0,0,0});
        mergeTiles(new int[]{0,2,0,0});
        mergeTiles(new int[]{0,0,2,0});
        mergeTiles(new int[]{0,0,0,2});

        mergeTiles(new int[]{2,2,0,0});
        mergeTiles(new int[]{2,0,2,0});
        mergeTiles(new int[]{2,0,0,2});

        mergeTiles(new int[]{0,2,2,0});
        mergeTiles(new int[]{0,2,0,2});
        mergeTiles(new int[]{0,0,2,2});

        mergeTiles(new int[]{2,2,2,0});
        mergeTiles(new int[]{2,0,2,2});
        mergeTiles(new int[]{2,2,0,2});
        mergeTiles(new int[]{0,2,2,2});

        mergeTiles(new int[]{2,2,2,2});


    }

    private static void mergeTiles(int[] tiles) {
        int n = tiles.length;
        for (int i = 0; i < n - 1; i++) {
            if (tiles[i] == tiles[i+1]) {
                int newValue = tiles[i] * 2;
                tiles[i] = newValue;
                for (int j = i + 1; j < n - 1; j++) {
                    tiles[j] = tiles[j+1];
                }
                tiles[n-1] = 0;
            }
        }
        System.out.println(Arrays.toString(tiles));
    }
}

Guadalupe Gagnon

Level 37 , Tampa, United States

23 January 2020, 16:28

Here is some test code for you. The outputs don't match the task requirements in a bunch of the cases. There should be no number '0' to the right of any numbers.

Elvis Lee

Level 41 , Aurora, United States

27 January 2020, 20:51

Hi Guadalupe, I found my code is correct. I used the int[] for testing the logic in Main and made a mistake in the Model that assigning the value tiles[j] = tiles[j+1], I should use tiles[j].setValue(tiles[j+1].value). Anyway, thank you so much checking my code!!