Last condition is failing

Question about the task

Under discussion

Hi there, The code is fine whatever you throw at it (as far as I am concerned), yet it fails on the last one. Nothing is returned if n <= 0 Any help? Thanks

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int nNumber = Integer.parseInt(reader.readLine()); int greatest = Integer.parseInt(reader.readLine()); if (nNumber <= 0) { return; } if (nNumber > 0) { while (nNumber - 1 > 0) { int numerki = Integer.parseInt(reader.readLine()); greatest = greatest > numerki ? greatest : numerki; nNumber--; } System.out.println(greatest); } //write your code here //System.out.println(maximum); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

manpreet singh

Level 6 , Ottawa, Canada

3 May 2020, 06:22

it can be done without using Min_value. https://codegym.cc/help/9251

Ntuthuko Xaba

Level 18 , Johannesburg, South Africa

9 February 2020, 19:19

Looks about right to me , but try inserting this line before printing - "if (greatest > 0)" , which will make your code look like this: if (greatest > 0) System.out.println(greatest);

Bartlomiej Drozd

Level 22

10 February 2020, 22:58

I did try it, eventually I had to go with MIN_VALUE and it passed alright. Thanks for the comment though, appreciated!

Krystian C

Level 27 , San Francisco, United States

9 February 2020, 18:17

Spróbuj tak. A mam pytanie. Czy nie studiowałeś czasami na UMCS? :D

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int nNumber = Integer.parseInt(reader.readLine());


        if (nNumber > 0) {

            int greatest = Integer.parseInt(reader.readLine());

            while (nNumber - 1 > 0)
            {

                int numerki = Integer.parseInt(reader.readLine());

                greatest = Math.max(greatest, numerki);
                nNumber--;

            }


            System.out.println(greatest);
        }

        //write your code here

        //System.out.println(maximum);
    }
}

Bartlomiej Drozd

Level 22

10 February 2020, 23:00

Nie studiowalem :) Rowniez ten kod nie dzialal. Probowalem rozwiazania kolegi z gory. Skonczylo sie na tym ze greatest wbilem jako MIN_VALUE, pozdro: public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int nNumber = Integer.parseInt(reader.readLine()); int greatest = Integer.MIN_VALUE; if (nNumber > 0) { while (nNumber > 0) { int numerki = Integer.parseInt(reader.readLine()); greatest = greatest > numerki ? greatest : numerki; nNumber--; } System.out.println(greatest); } } }