whats wrong

Question about the task

Archived

i think it no problem, but.... help me ,plz thank u a lot !! ;)

1. Create a list of strings.
2. Read 5 strings from the keyboard and add them to the list.
3. Using a loop, find the shortest string in the list.
4. Display the string.
5. If there is more than one, display each on a new line.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 5 strings from the keyboard and write them to the list.
The program should display the shortest string.
If several strings are the shortest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0709; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; /* Expressing ourselves more concisely */ public class Solution { public static void main(String[] args) throws Exception { //write your code hereint int min=0; ArrayList<String>strings = new ArrayList<String>(); ArrayList<Integer> ttt = new ArrayList<Integer>(); for(int i =0;i<5;i++) { BufferedReader reader =new BufferedReader(new InputStreamReader(System.in)); String s = reader.readLine(); strings.add(s); ttt.add(s.length()); min = ttt.get(0); min = ttt.get(i) <= min ? ttt.get(i) : min ; } for(int i =0;i<5;i++) { int b = ttt.get(i); if ( b==min) System.out.println(strings.get(i)); } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Skynet

Level 40 , USA

27 February 2020, 12:18

solution

First of all, work on the readability of your code. Read "Clean Code" by Robert Martin. Did you seriously name your list "ttt"? Secondly, you can just use the first for loop to add words to the first list of strings, then, after the loop get the minimum string by using:

String min = Collections.min(yourListNameHere, Comparator.comparing(String::length));

You can then go through your list of strings in a second for loop and compare each item to variable min. If there are any strings that are the same length as min, add them to the second list of integers. Then, after the second loop, display all entries of the second list with a one-liner:

secondListNameHere.forEach(System.out::println);

hidden #10589341

Level 19

27 February 2020, 12:33

thank you !! :)