Works in repl.. Why is it not being verified?

Question about the task

Resolved

package com.codegym.task.task05.task0529;

import java.io.BufferedReader;
import java.io.InputStreamReader;

/*
Console-based piggy bank

*/

public class Solution {
    public static void main(String[] args) throws Exception {
       BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
    int total = 0;
    String s = "sum";
    String firstNumber = reader.readLine();

    while(!(firstNumber.equals(s))){
      String sNumber = reader.readLine();

      if(sNumber.equals(s)){
        System.out.print(total + Integer.parseInt(firstNumber));
      }else {
        int number = Integer.parseInt(sNumber);
        total += number;
      }
    }

    }
}

Use the keyboard to enter numbers and calculate their sum until the user enters the word "sum".
Display the resulting sum on the screen.

Hint: to read from the keyboard until the string 'exit' is input, do this:

BufferedReader buffer = new BufferedReader(new InputStreamReader(System.in));
while (true)
{
	String s = buffer.readLine();
	if (s.equals("exit"))
		break;
}

Requirements:

The program must read data from the keyboard.
The program should stop reading data from the keyboard after the user enters the word "sum" in lowercase letters and presses Enter.
The program should work correctly if the user enters one number and the word "sum".
The program should work correctly if the user enters two numbers and the word "sum".
The program should work correctly if the user enters more than two numbers and the word "sum".
The program should display text on the screen.

package com.codegym.task.task05.task0529; import java.io.BufferedReader; import java.io.InputStreamReader; /* Console-based piggy bank */ import java.util.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int total = 0; //String s = "sum"; String firstNumber = reader.readLine(); while(!(firstNumber.equals("sum"))){ String sNumber = reader.readLine(); if(sNumber.equals("sum")){ System.out.print(total + Integer.parseInt(firstNumber)); }else { int number = Integer.parseInt(sNumber); total += number; } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Ankush Rajput

Level 25 , Bhopal, India

11 October 2018, 02:35

useful

Lets analyze what your code is doing. Consider input - 1,2,sum. In line 16, you are reading input and storing it in String firstNumber. 1 gets stored in firstNumber. After this, the code will move to while loop and will check for condition whether firstNumber is equal to sum or not. Notice that firstNumber is outside while loop. 1 is stored in it. Once your program starts executing while loop, firstNumber will keep storing 1 and will never change. while loop will run as an infinite loop. Got your mistake ? You don't need firstNumber and sNumber to solve this problem. It can be solved with any one. while loop can be initialized as below -

String firstNumber;
while(!((firstNumber = reader.readLine()).equals("sum")))
{
//do something
}

WatWat

Level 9 , Vancouver, Canada

11 October 2018, 03:10

Wow thats super interesting, thank you Ankush. I will try it with your solution but for now I just put a break; inside the if statement and it worked thanks to your analysis

Ankush Rajput

Level 25 , Bhopal, India

11 October 2018, 03:54

Hey, sorry, I did a mistake in my code. It should be like this -

String firstNumber;
while(!((firstNumber = reader.readLine()).equals("sum")))
{
//do something
}

Corrected it in original comment also.

WatWat

Level 9 , Vancouver, Canada

11 October 2018, 04:57

Much appreciated and helpful :D