Whats the problem with my code? Keeps failing last check

Question about the task

Under discussion

public class Cat {
    public int age;
    public int weight;
    public int strength;

    public Cat() {
    }

    public boolean fight(Cat anotherCat) {

        if (this.age <= anotherCat.age && this.weight >= anotherCat.weight && this.strength >= anotherCat.strength){
            return true;
        }
        else {
            return false;
        }

    }
    public static void main(String[] args) {
        Cat cat1 = new Cat();
        Cat cat2 = new Cat();
        cat1.age = 10;
        cat2.age = 20;
        cat1.weight = 20;
        cat2.weight = 10;
        cat1.strength = 30;
        cat2.strength = 20;
        System.out.println(cat1.fight(cat2));
        System.out.println(cat2.fight(cat1));
    }
}

Implement the boolean fight(Cat anotherCat) method:
implement a mechanism for cats to fight based on their weight, age and strength.
You can decide for yourself how a cat's characteristics factor into combat.
The method should determine whether we (this) won the fight, i.e. return true if we won and false if not.

The following condition must be met:
if cat1.fight(cat2) returns true,
then cat2.fight(cat1) must return false

Requirements:

The Cat class must have a constructor with no parameters.
The Cat class must contain public fields age, weight, and strength.
The Cat class must have a fight method.
In the fight method, implement a mechanism for cats to fight based on their weight, age and strength.
The method should return the same value every time we fight the same cat.
If cat1 beats cat2, then cat2 must lose to cat1.

package com.codegym.task.task05.task0502; /* Implement the fight method */ public class Cat { public int age; public int weight; public int strength; public Cat() { } public boolean fight(Cat anotherCat) { if (this.age <= anotherCat.age && this.weight >= anotherCat.weight && this.strength >= anotherCat.strength){ return true; } else { return false; } } public static void main(String[] args) { Cat cat1 = new Cat(); Cat cat2 = new Cat(); cat1.age = 10; cat2.age = 20; cat1.weight = 20; cat2.weight = 10; cat1.strength = 30; cat2.strength = 20; System.out.println(cat1.fight(cat2)); System.out.println(cat2.fight(cat1)); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

5 March 2020, 14:35

take for example two cats that are both 8 years old. Both have 15 strength and weigh 10 pounds. When you use this method like this: cat1.fight(cat2) would that return true or false? cat2.fight(cat1) would that return true of false? The thing is in this scenario both methods would return true which is a violation of the contraint: The following condition must be met: if cat1.fight(cat2) returns true, then cat2.fight(cat1) must return false

Skynet

Level 40 , USA

5 March 2020, 14:28

Try this for the fight() method:

int cat1Counter = 0;
int cat2Counter = 0;
int age = this.age < anotherCat.age ? cat1Counter++ : cat2Counter++;
int weight = this.weight > anotherCat.weight ? cat1Counter++ : cat2Counter++;
int strength = this.strength > anotherCat.strength ? cat1Counter++ : cat2Counter++;

return cat1Counter > cat2Counter;