What is wrong in the code?

Question about the task

Task about algorithms

Java Syntax, Level 5, Lesson 12

Under discussion

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); int maximum = n; //write your code here while (n>0){ n = Integer.parseInt(reader.readLine()); if (n> maximum) maximum = n; System.out.println(maximum); } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Ashish RajAnand

Level 13 , Bhilai , India

4 May 2020, 13:24

I think task is that read a number N =5 and then read number of N that are 12,23,345,46,67 and place the print statement outside the loop . And you must the to decrease the value of N otherwise you move the infinite loop because N>0 always true. whenever number of iteration is fixed use for loop otherwise while loop

AnnemiekFF

Level 41 , Breda, Netherlands

4 May 2020, 09:47

You want to move the System.out to after the while loop. And you want to keep your N seperate from your max and your next read input. Otherwise you keep changing the condition for the loop and you can end up with either less or more numbers than N, also you wouldn't be able to do negative numbers like this, because you change the n.