Can't seem to figure out where the copying goes wrong

Question about the task

Let's make the code do something useful!

Under discussion

Tried looking at the other questions on this task but to no avail. Someone recommended using a for loop with the try-catch inside but it seems redundant to me. Anyone has any ideas on what to change to get my code working?

Task: The program reads in two file names. It copies the first file to the location specified by the second file name.
New task: The program reads in two file names. It copies the first file to the location specified by the second file name.
If the specified file (to be copied) does not exist, then the program should display "File does not exist." and read a file name one more time and only then read the destination file name.

Requirements:

The program must read file names.
The main method must handle exceptions thrown by the getInputStream method. If an exception occurs, you should display "File does not exist.".
The program must copy the contents of the first file to the second one.
The main method should call the getInputStream method.
Don't change the getInputStream method.
The main method should call the getOutputStream method.
Don't change the getOutputStream method.

package com.codegym.task.task09.task0929; import java.io.*; /* Let's make the code do something useful! */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String sourceFileName = reader.readLine(); String destinationFileName = reader.readLine(); try{ InputStream fileInputStream = getInputStream(sourceFileName); OutputStream fileOutputStream = getOutputStream(destinationFileName); while (fileInputStream.available() > 0) { int data = fileInputStream.read(); fileOutputStream.write(data); } fileInputStream.close(); fileOutputStream.close(); } catch (Exception e){ System.out.println("File does not exist."); String newSourceFileName = reader.readLine(); InputStream fileInputStream = getInputStream(newSourceFileName); OutputStream fileOutputStream = getOutputStream(destinationFileName); while (fileInputStream.available() > 0) { int data = fileInputStream.read(); fileOutputStream.write(data); } fileInputStream.close(); fileOutputStream.close(); } } public static InputStream getInputStream(String fileName) throws IOException { return new FileInputStream(fileName); } public static OutputStream getOutputStream(String fileName) throws IOException { return new FileOutputStream(fileName); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Timboo

Level 16 , Shantou, China

21 July 2020, 02:08

The purpose of the Question: 1. If the first source file name doesn't exist, u need to get a new source file name and read once name again.(Try..catch.. for the getInputStream)

package com.codegym.task.task09.task0929;

import java.io.*;

/*
Let's make the code do something useful!

*/

public class Solution {
    public static void main(String[] args) throws IOException {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

        String sourceFileName = reader.readLine();

        InputStream fileInputStream = null;
        try {
            fileInputStream = getInputStream(sourceFileName);
        }
        catch(IOException e) {
            System.out.println("File does not exist.");
            String newSourceFileName = reader.readLine();
            fileInputStream = getInputStream(newSourceFileName);
        }

        String destinationFileName = reader.readLine();
        OutputStream fileOutputStream = getOutputStream(destinationFileName);

        while (fileInputStream.available() > 0) {
            int data = fileInputStream.read();
            fileOutputStream.write(data);
        }

        fileInputStream.close();
        fileOutputStream.close();
    }

    public static InputStream getInputStream(String fileName) throws IOException {
        return new FileInputStream(fileName);
    }

    public static OutputStream getOutputStream(String fileName) throws IOException {
        return new FileOutputStream(fileName);
    }
}

Ashish RajAnand

Level 13 , Bhilai , India

6 May 2020, 11:28

see and analys what mistake you made

public static void main(String[] args) throws IOException {
       BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

      // String sourceFileName = reader.readLine();

       InputStream fileInputStream = null;
       try {
           String sourceFileName = reader.readLine();
           fileInputStream = getInputStream(sourceFileName);
       }  catch (FileNotFoundException e){
           System.out.println("File does not exist.");
           String sourceFileName = reader.readLine();
           fileInputStream = getInputStream(sourceFileName);
       }

       String destinationFileName = reader.readLine();
       OutputStream fileOutputStream = getOutputStream(destinationFileName);

       while (fileInputStream.available() > 0) {
           int data = fileInputStream.read();
           fileOutputStream.write(data);
       }

       fileInputStream.close();
       fileOutputStream.close();
   }