not able to find what is going wrong.

Question about the task

Resolved

Please provide me the test file which must be passing. i tried few files and it worked. so , not able to know what is the issue. Please help me with some examples where it fails . thanks

The main method's first parameter is file1 and the second is file2.
file1 contains words separated by spaces.
Write to file2 a comma-separated list of words longer than 6 characters.
file2 should not end with a comma.
Close the streams.

Example output to file2:
lengthy,shortened,abbreviation

Requirements:

The program must NOT read data from the console.
The program must read the first file's contents (use the FileReader constructor with a String parameter).
The file input stream (FileReader) must be closed.
The program should write to the second file all the words from the first file longer than 6 characters, separated by commas (use FileWriter).
The file output stream (FileWriter) must be closed.

package com.codegym.task.task19.task1925; /* Long words */ import java.io.*; public class Solution { public static void main(String[] args) throws IOException { //storing argument value String fileOne=args[0]; String fileTwo=args[1]; //reading file1 FileReader fileReader = new FileReader(fileOne); BufferedReader bufferedReader = new BufferedReader(fileReader); //writing to file2 FileWriter fileWriter = new FileWriter(fileTwo); BufferedWriter bufferedWriter = new BufferedWriter(fileWriter); while (bufferedReader.ready()) { String line = bufferedReader.readLine(); String wordsInLine[] = line.split("\\s"); for (int i = 0; i < wordsInLine.length; i++) { //System.out.println("check1"); if (wordsInLine[i].length() > 6) { // System.out.println("check2"); if ((i == wordsInLine.length - 1) && (!bufferedReader.ready())) { bufferedWriter.write(wordsInLine[i]); // System.out.println(wordsInLine[i]); } else { bufferedWriter.write(wordsInLine[i] + ","); // System.out.print(wordsInLine[i] + ","); } } } } fileReader.close(); bufferedReader.close(); bufferedWriter.close(); fileWriter.close(); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

AnnemiekFF

Level 41 , Breda, Netherlands

9 May 2020, 15:08

solution

What I would imagine from your code to happen is that if the last word is not longer than 6 letters you end with a , instead of with a word. What I did to solve that was write every word that is longer than 6 to a StringBuilder. Then create a string after the loop from the StringBuilder and make a substring without the last character and write that one to the new file.

Manish Sinha

Level 26 , london, United Kingdom

9 May 2020, 21:38

Thanks AnnemiekFF for highlighting the problem in my code and thanks agains for suggesting way to solve it. Very useful to know what is the error in my code.