why its not going through verification?

Question about the task

Under discussion

hi, can anyone explain me why it is not going through verification? Everything works, but not even one condition is met. Thanks

The first strategy is ready. It's time to test it. To do this:
6.1. Create a Solution class if you haven't already done so.
6.2. Add implementations of the static helper methods to the Solution class:
6.2.1. Set<Long> getIds(Shortener shortener, Set<String> strings). This method should return a set of identifiers for a passed set of strings. You need to use shortner to get the identifier for each individual string.
6.2.2. Set<String> getStrings(Shortener shortener, Set<Long> keys). The method will return the set of strings that matches the passed set of identifiers.
Of course, when you use Shortener for its actual purposes, you probably won't have to get a set of identifiers from a set of strings, nor vice versa. This task is only necessary for testing.
6.2.3. testStrategy(StorageStrategy strategy, long elementsNumber). The method will test the passed strategy on a specific number of elements (elementsNumber). The implementation should:
6.2.3.1. Display the name of the class strategy. The name must not include the package name.
6.2.3.2. Generate a test set using Helper and the specified number of elements (elementsNumber).
6.2.3.3. Create a Shortener object using the passed strategy.
6.2.3.4. Measure and display the time required to run the getIds method for the given strategy and the given set of elements. Display time in milliseconds. When measuring the method's execution time, you can ignore the processor switching to other threads, as well as the time spent on the call itself, returning values, and calling methods to get the time (date). Measure time using Date objects.
6.2.3.5. Measure and display the time required to run the getStrings method for a given strategy and the set of identifiers obtained in the previous clause.
6.2.3.6. Check whether the contents of the set of generated strings and the set returned by getStrings method are the same. If the sets are the same, then display "The test passed.". Otherwise, display "The test failed.".
6.2.4. Add a main() method. Inside the method, test the HashMapStorageStrategy strategy on 10,000 items.
6.3. Verify that the program works and the test is passed.

Requirements:

The getIds method must return the set of identifiers for the passed set of strings.
The getStrings method must return the set of strings for the passed set of identifiers.
The testStrategy method should display the name of the strategy class.
The testStrategy method should generate a test set of strings using the Helper class's generateRandomString method (the number of elements must be equal to the elementsNumber parameter).
The testStrategy method must create a Shortener object using the passed strategy.
The testStrategy method should use Date objects to measure the execution time of the getIds and getStrings methods.
The testStrategy method should compare the number of generated strings and the strings in the set obtained from the getStrings method, and display the result of the test.
The main method must call the testStrategy method.

package com.codegym.task.task33.task3310; import com.codegym.task.task33.task3310.strategy.HashMapStorageStrategy; import com.codegym.task.task33.task3310.strategy.StorageStrategy; import java.util.Date; import java.util.HashSet; import java.util.Iterator; import java.util.Set; import java.util.stream.Collectors; public class Solution { private static Set<Long> getIds(Shortener shortener, Set<String> strings){ return strings.stream().map(shortener::getId).collect(Collectors.toSet()); } private static Set<String> getStrings(Shortener shortener, Set<Long> keys){ return keys.stream().map(shortener::getString).collect(Collectors.toSet()); } private static void testStrategy(StorageStrategy strategy, long elementsNumber){ System.out.println(strategy.getClass().getSimpleName()); Set<String> test = new HashSet<>(); for(int a=0; a<elementsNumber; a++){ test.add(Helper.generateRandomString()); } Shortener sh = new Shortener(strategy); // zacat pocitat cas ms Date start = new Date(); Set<Long> testId = getIds(sh, test); Date stop = new Date(); // ukoncit pocitat cas ms long inMs = stop.getTime() - start.getTime(); // ako dlho trvalo System.out.println("Method getIds time run: " + inMs); ////////////////////// Date start1 = new Date(); Set<String> testStrings = getStrings(sh, testId); Date stop1 = new Date(); inMs = stop1.getTime() - start1.getTime(); System.out.println("Method getStrings time run: " + inMs); if(test.containsAll(testStrings) && testStrings.containsAll(test)) System.out.println("The test passed."); else System.out.println("The test failed."); } public static void main(String[] args) { Solution.testStrategy(new HashMapStorageStrategy(), 10000L); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

4 September 2020, 16:15

#1The first task in this BIG task says: "P.S. Make all methods public and fields private if there are no explicit instructions regarding access modifiers." If you look, the verification system is testing each method in this code individually. Having the methods private will prevent the. #2 You should also be using the Helper method, specifically the printMessage(), and not System.out.println(). #3 These methods are static, you don't call static methods from the same class using the class name. Remove "Solution." from line 58.

Marek Durovic

Level 41 , Bratislava, Slovakia

5 September 2020, 13:18

thank you, changing methods from private to public helps. #2 was not an issue, because it was done in task before