I get the right answer but still fail

Question about the task

Resolved

See code below. I've tried running it with a variety of years, both leap and non leap; ones that are divisable with 400, 100 and 4. I get the right answer but the last requirement is never met. Thanks in advance.

Use the keyboard to enter a year, and then determine the number of days in the year. Display the result as follows:
Number of days in the year: x
, where
x is 366 for a leap year, and
x is 365 for an ordinary year.

Hint:
A leap year is 366 days, but an ordinary year is 365 days.
1) if the year is evenly divisible by 400, then it is a leap year;
2) for other years, if the year is evenly divisible by 100, then it is a regular year;
3) for other years, if the year is evenly divisible by 4, then it is a leap year;
4) all remaining years are not leap years.
Thus, the years 1700, 1800, and 1900 are not leap years, since they are multiples of 100 but not 400.
The years 1600 and 2000 are leap years, since they are multiples of 100 and multiples of 400.
The years 2100, 2200 and 2300 are not leap years.

Requirements:

The program should read a number from the keyboard.
The program should display text on the screen according to the task conditions.
If the entered year is a leap year, you should display: "Number of days in the year: 366".
If the entered year is not a leap year, you should display: "Number of days in the year: 365".

package com.codegym.task.task04.task0414; /* Number of days in the year */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader bR = new BufferedReader(new InputStreamReader(System.in)); int x = Integer.parseInt(bR.readLine()); if (x % 400 == 0) { x = 366; } else if (x % 100 == 0) { x = 365; } else if (x % 4 == 0) { x = 366; } System.out.println("Number of days in the year: " + x); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

24 June 2021, 14:08

4) all remaining years are not leap years. means you need to add an else block and set x to 365 currently you output the entered year for that years (4. ) instead of 365 (eg. for 2021)

Usman Full Stack Developer at QA

24 June 2021, 14:15

oh haha... i got it thank you so much, Thomas! I tidied it up aswell a little, with more descriptive variables :)

public class Solution {
    public static void main(String[] args) throws Exception {

        BufferedReader bR = new BufferedReader(new InputStreamReader(System.in));
        int year = Integer.parseInt(bR.readLine());
        int days = 0;

        if (year % 400 == 0) {
            days = 366;
        } else if (year % 100 == 0) {
            days = 365;
        } else if (year % 4 == 0) {
            days = 366;
        } else {
            days = 365;
        }
        System.out.println("Number of days in the year: " + days);
    }
}

Thomas

Level 41 , Bayreuth, Germany

24 June 2021, 14:19

nice ;) another approach would be to use a boolean like:

boolean leapYear = false;

if (x % 400 == 0) {
    leapYear = true;
} else if (x % 100 == 0) {
    // leapYear = false; // leapYear already is false but we need to get out of the if cascade
} else if (x % 4 == 0) {
    leapYear = true;
}
// else leapYear = false; // we do not need it anymore, leapYear already is false
System.out.println("Number of days in the year: " + (leapYear ? 366 : 365));

Usman Full Stack Developer at QA

24 June 2021, 16:19

i like it i like it