code working, but not pass task.

Question about the task

Resolved

but why task not accepting the code? whats wrong? and i from phone writing and there very often window with text long time ... . and not compile.

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose_0"); // 0 list.add("love_1"); // 1 list.add("lyre_2"); // 2 list = fix(list); // "love" 2 all 3 for (String s : list) { System.out.println(s); } } //--------------- public static ArrayList<String> fix(ArrayList<String> list) { ArrayList<String> st = new ArrayList <String>(); // st.add("lyre"); int i = 0, c = list.size(); int a1, a2; for( i = 0 ;i < c; ) { a1 = 0; a2 = 0; // char compare for (int x = 0; x < list.get(i).length(); x++) { char ch = list.get(i).charAt(x); if ( ch == 'r' ) a1 = 1; if ( ch == 'l' ) a2 = 1; } // for x if (!(st.size() == 0)) { for (int x1 = 0; x1 < st.size();x1++) { if (list.get(i).equals(st.get(x1) ) ) { i++; } else { if ((a1 == 1) && ( a2 == 0)) { list.remove(i); } if ((a1 == 0) && ( a2 == 1)) { list.add(list.get(i)); st.add(list.get(i));i++; } if ((a1 == 1) && ( a2 == 1)) { i++; } // System.out.println(" false "); } } } else { if ((a1 == 1) && ( a2 == 0)) { list.remove(i); } if ((a1 == 0) && ( a2 == 1)) { list.add(list.get(i)); st.add(list.get(i));i++; } } } return list; } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Gellert Varga

Level 23 , Szekesfehervar, Hungary

19 November 2021, 22:09

Try your program with the same test list:

list.add("rose_0"); //  - DEL!
list.add("love_1"); //  - DUPL!
list.add("lyre_2"); //  - NOTHING
list.add("lyre_3"); //  - NOTHING
list.add("lyvia_4"); //  - DUPL
list.add("rosie_5"); //  - DEL!
list.add("rosa_6"); //  - DEL!
list.add("something_7"); //  - NOTHING
list.add("something_8"); //  - NOTHING
list.add("road_9"); //  - DEL!
list.add("board_10"); //  - DEL!

and you will arrive into an infinite loop... So unfortunately, we can not say "code working." It have to work not only with that 3 string in the example code.

Gellert Varga

Level 23 , Szekesfehervar, Hungary

19 November 2021, 23:12

I think your programme is getting more and more complicated... E.g. as Lisa suggested in your previous post, I think that would be an easy to understand very good way to solve this task: Her idea is this: - to create a new empty list, and - add to the new list TWICE the current index if it contains "l" and doesn't contain "r", - DO NOT ADD to the new list the current index if it contains "r" and doesn't contain "l", - add the current index to the new list in any other case, simply once. - Go through all the elements of original list, with the steps above, then finish the loop (for int i < originalList.size() ) - the method have to return the new list. First always try to write down the steps what to do. And when the steps detailing is done, just then write Java code.

Onar D.

Level 7

20 November 2021, 09:44

from phone , when i added you lines, text appeared: "the programm run too long" . it 's not compile the code. better from pc . but i dont have one. and this promblem very often show up. just sad i cant see result. if add this lines.

Gellert Varga

Level 23 , Szekesfehervar, Hungary

20 November 2021, 20:51

Try to get a cheap second-hand computer. The code is compiled, even if I paste the suggested test code. It just executes an infinite loop due to a logic error = never ends = runs too long. Try this online IDE, test your programs here: https://www.jdoodle.com/online-java-compiler/ I like it! It's free, and I think it's better than the IDE on CodeGym's website. I guess you can use it on your phone.

Onar D.

Level 7

21 November 2021, 21:27

thanks. figure out something.