I am stuck!

Question about the task

Iterating through a file tree

Java Collections, Level 1, Lesson 2

Resolved

I can't pass the condition no 3 because i don't include files from subdirectorys. Any hint? Tk you!

1. The main method is passed two arguments as inputs.
The first argument is path, which is the path to the directory; the second is resultFileAbsolutePath, which is the name (full path) of an existing file that will store the result.
2. For each file in the path directory and in all of its subdirectories, do the following:
For each file whose size in bytes is NOT greater than 50, do the following:
2.1. Sort them by file name in ascending order. Don't include the path when sorting.
2.2. Rename resultFileAbsolutePath to "allFilesContent.txt" (use the FileUtils.renameFile method and FileUtils.isExist if necessary).
2.3. Sequentially write the contents of each file from step 2.1 to allFilesContent.txt. After the body of each file, write "\n".
All files have the TXT extension.
Use "/" as the path separator.

Requirements:

The file passed as the second argument to main must be renamed to allFilesContent.txt.
You need to create a stream to write to the renamed file.
The contents of every file that is 50 bytes or smaller must be written to the allFilesContent.txt file.
The output stream to the file must be closed.
Don't use static variables.

package com.codegym.task.task31.task3101; /* Iterating through a file tree */ import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.ArrayList; import java.util.List; import java.util.Objects; public class Solution { public static void main(String[] args) throws IOException { String path = args[0]; String resultFileAbsolutePath = args[1]; File dir = new File(path); File file = new File(resultFileAbsolutePath); File fuk = new File(file.getParent()+ "\\allFilesContent.txt"); FileUtils.renameFile(file, fuk); FileOutputStream fileOutputStream = new FileOutputStream(fuk); File[] listFiles = dir.listFiles(); List<File> list = writeFile(listFiles); for(File file1 : list){ FileInputStream fileInputStream = new FileInputStream(file1); while (fileInputStream.available() > 0){ int data = fileInputStream.read(); fileOutputStream.write(data); } fileOutputStream.write(10); fileInputStream.close(); } fileOutputStream.close(); } public static List<File> writeFile(File[] files) throws IOException { List<File> list = new ArrayList<>(); long l = 51; if(files != null) { for (File file1 : files) { if (!file1.isDirectory()) { Path path1 = Paths.get(file1.getPath()); long bytes = Files.size(path1); if (bytes < l) { list.add(file1); } } else { File[] x = file1.listFiles(); writeFile(x); } } } return list; } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Ramen

Level 23 , South Lake Tahoe, United States

7 August 2023, 05:50

using .length() instead of .size() fixes the issue

Justin Smith

Level 41 , Greenfield, USA, United States

27 July 2022, 20:20

This part of the problem screamed out recursion to me. I am still working on this and have not passed yet, so I can't promise there isn't an error here, but this is what I'm working with at the moment:

public static ArrayList<String> getFilesList(String path)
{
    ArrayList<String> returnList = new ArrayList<>();
    File directory = new File(path);
    if(directory.isDirectory())
    {
        for (String fileString : directory.list())
        {
            returnList.addAll(getFilesList(directory.getAbsolutePath() + "\\" + fileString));
        }
    }
    else if(directory.length() <= 50)
    {
        returnList.add(path);
    }
    return returnList;
}

Thomas

Level 41 , Bayreuth, Germany

28 July 2022, 05:43

If you use the frame Lisa posted then things get easier

public static void main(String[] args) throws IOException {
    getAllFiles(new TreeSet<>(), new File(args[0])).forEach(file -> System.out.println(file.getName()));
}

public static Set<File> getAllFiles(Set<File> allFiles, File root) {
    for (File current : root.listFiles()) {
        if (current.isFile() && current.length() <= 50)
            allFiles.add(current);
        else if (current.isDirectory())
            getAllFiles(allFiles, current);
    }
    return allFiles;
}

You also could use a static field to save a reference to the set. Then you do not need to carry the collection with you. But I think Lisa avoided that cause of CodeGym being picky validating static members in some tasks.

Lisa L

Level 47 , Nuremberg, Germany

17 March 2022, 10:07

solution

2. For each file in the path directory and in all of its subdirectories, do the following: listFiles() just returns Files inside the passed File. It does not iterate into the containing direcories. So you either write a method that can do that for you or you use the FileVisitor like in your other question. If you go for your own implementation than the easiest approach would be a recursive method like

public static Set<File> getAllFiles(Set<File> allFiles, File root) {
    // go through all File objects in root -> for (... : root.listFiles()) {
        // if file add to allFiles
        // if path, call getAllFiles(allFiles, currentFile);
    // return the set
}

you could add a check if root is a directory

Angel Stefan

Level 23 , Sibiu, Romania

19 March 2022, 23:30

OMG it worked, i use the recursive method. I made some small change in my code and... Tk you!