Doesn't pass, while it seems correct.

Question about the task

Resolved

Seems I'm struggling with this lesson. I believe it outputs the second smallest number, however I keep failing on these conditions. Could someone point me in the right direction? on why it's still not correct.

In this task, you need to:

Read integers from the keyboard until something else is entered, such as a string or a character.
At least two numbers must be entered. If less than two integers are entered, then terminate the program with an error. You don't need to handle this situation.
Display the second smallest integer entered from the keyboard. If several such numbers are entered, you must display any of them.
There may also be several minimum numbers.

Example input:

8

4 // Minimum number

7

4 // Minimum number

5 // Second smallest number

9

5 // Second smallest number

exit

Example output:
5

Requirements:

The program should read numbers from the keyboard.
The program should display a number on the screen.
The program should display the second smallest integer entered.
If several second smallest numbers are entered, then you need to display any one of them.
You need to read data from the keyboard in a while loop.

package en.codegym.task.pro.task04.task0410; import java.util.Scanner; /* Second smallest number entered */ public class Solution { public static void main(String[] args) { Scanner s = new Scanner(System.in); boolean x = true; int secondSmallestInt = Integer.MAX_VALUE; int min = Integer.MAX_VALUE; int count = 0; while (x){ if (s.hasNextInt()) { int a = s.nextInt(); count++; if (a < min) min = a; if (a < min && a > secondSmallestInt) { secondSmallestInt = min; min = a; }else if ( a>min && a<secondSmallestInt){ secondSmallestInt = a; } } else if (s.hasNextLine()){ String exit = s.nextLine(); x = false; } } if (count>1) System.out.println(secondSmallestInt); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

28 November 2023, 12:05

there are some logic problems eg.

if (a < min) min = a;

If a is smaller than min then you set min = a next check

if (a < min && a > secondSmallestInt)

a can not be smaller than min anymore. The only possibility it has is to be equal or greater than min. The next check a > secondSmallestInt ?? What do you intend that to be? a can not be smaller than smallest number and at the same time be greater than the second smallest number? The body of this condition never will be executed. What you really intended to do is probably to set secondMin to min and min to the input if the input is smaller than min (so delete 25 - 28 and instead set secondMin to min before min to input). the rest looks good and you also considered input == min in that next condition. side note, that works, too while (s.hasNextInt()) { (instead of while (condition) if (hasNextInt...))

JMDL0203

Level 9 , The Hague, Netherlands

28 November 2023, 13:10

Thank you for the feedback/support!