I get the exact result that we need. Why does it fail validation?

Question about the task

Under discussion

If someone wants to explain to me how my version doesn't get the exact same version CodeGym's solution generates, I would love to hear it! Thank you!

The getPartOfString method must return the substring that begins with the character after the first space and ends with the end of the word that follows the 4th space.

Example:
"CodeGym is the best place to learn Java."

Result:
"is the best place"

Example:
"Amigo and Diego are best friends!"

Result:
"and Diego are best"

If the input data is invalid, throw a StringTooShortException (create an exception).

Requirements:

The StringTooShortException class must be a child of the RuntimeException class.
The getPartOfString method must have a String parameter.
If invalid data is passed to the getPartOfString method, a StringTooShortException should be thrown.
The getPartOfString method must return the substring that begins with the character after the first space and ends with the word that follows the 4th space.

package com.codegym.task.task22.task2202; /* Find a substring */ public class Solution { public static void main(String[] args) throws StringTooShortException { System.out.println(getPartOfString("CodeGym is the best place to learn Java.")); //System.out.println(getPartOfString("Amigo and Diego are best friends!")); //System.out.println(getPartOfString("")); } public static String getPartOfString(String string) throws StringTooShortException { try { int indexOfFirstSpace = string.indexOf(" "); int spaceCount = string.indexOf(" "); for(int i=0; i<4; i++) { spaceCount = string.indexOf(" ", spaceCount+1); } return string.substring(indexOfFirstSpace+1, spaceCount); } catch (Exception e) { throw new StringTooShortException(); } } public static class StringTooShortException extends RuntimeException { } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

4 March, 04:18

I don't know if try-catch is invalid i this code but I can tell you that your code gets the substring between the 1st and the 5th space characters in the String but the task doesn't say to use the 5th space character. It specifically says to use the end of the word following the 4th space character. So if the String were: CodeGym is the best place then the valid return would be: is the best place To pass validation you you will need to fix this and the bug that Thomas mentioned about when less spaces than are needed for the algorithm are in the text String

Thomas

Level 41 , Bayreuth, Germany

3 March, 10:08

In my solution I have commented that it didn't work for me using try-catch. Why? I haven't found out due to not being able to revalidate. If that applies for you solution, too, I do not know. But your solution does not work for all strings with less than the required spaces properly. You'd need to check if spaceCount equals -1 after each iteration. That's because (from the docs): '... this method does not throw an exception when fromIndex is outside the valid range'. Means you iterate 4 times and eg the 2nd space is missing. The result is -1. In the third iteration you get indexOfFirstSpace == spaceCount (the index of the second space) and in the last iteration you get the index of the second space. And that is wrong. Eg. try: 'CodeGym is the' result: is In the end the try - catch block is not necessary as you have to check nontheless. You just need an additional null check and maybe you remove the unnecessary indexOf call in line 18 (same result as the call in line 17)