gives me the right result for the test cases, but won't verify

Question about the task

R or L

Java Syntax, Level 7, Lesson 9

Under discussion

any idea what's wrong with this?

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("surly"); // 1 list.add("love"); list.add("lyre"); list.add("wade"); list.add("bark"); // 2 list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { ArrayList<String> res = new ArrayList<String>(); for (int i = 0; i < list.size(); i++) { String s = list.get(i); if (s.contains("l") && s.contains("r")) { res.add(s); } else if (s.indexOf('l') >= 0 ) { res.add(s); res.add(s); } else if (s.indexOf('r') >= 0) { ; } } list.clear(); for (int i = 0; i < res.size(); i++) list.add(res.get(i)); return list; } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 March 2019, 20:47

The problem that I see is that you do not add words to 'res' in cases where they do not contain 'r' or 'l'. You need to make sure that words in this case are added to the temp list 'res'. This isn't going to make you fail, but lines 47 and 48 are unnecessary. You can just return 'res' instead of clearing 'list', adding everything in 'res', then returning 'list'.

JD Rudie

Level 13 , Oxford, United States

27 March 2019, 22:12

I was trying that before, but I assumed that the task somehow wanted me to return the parameter "list" since that's what was passed to the function. returning res also doesn't work.

JD Rudie

Level 13 , Oxford, United States

27 March 2019, 22:14

here's what it looks like when i remove that. still fails:

package com.codegym.task.task07.task0716;

import java.util.ArrayList;

/*
R or L

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        ArrayList<String> list = new ArrayList<String>();
        list.add("rose"); // 0
        list.add("surly"); // 1
        list.add("love");
        list.add("lyre");
        list.add("wade");
        list.add("bark"); // 2
        list = fix(list);

        for (String s : list) {
            System.out.println(s);
        }
    }

    public static ArrayList<String> fix(ArrayList<String> list) {
        ArrayList<String> res = new ArrayList<String>();

        for (int i = 0; i < list.size(); i++) {
            String s = list.get(i);

            if (s.contains("l") && s.contains("r")) {
                res.add(s);
            }

            else if (s.indexOf('l') >= 0 ) {
                res.add(s);
                res.add(s);
            }

            else if (s.indexOf('r') >= 0) {
                ;
            }

        }

        return res;
    }
}

Guadalupe Gagnon

Level 37 , Tampa, United States

28 March 2019, 05:04

Returning list or res wasn't the problem, that was just a suggestion for more efficient code. The problem is words like "dog", "hat", "pinecones" (that dont contain 'r' or 'l')should all be added to the new list. Right now your code ignores them and they never get added and subsequently printed to screen.

JD Rudie

Level 13 , Oxford, United States

28 March 2019, 06:03

ohhhhh ok! the directions were confusing -- i guess i interpreted leave it unchanged as just don't put it in the new list. thanks ! :)