Timeout on validation

Question about the task

Resolved

Getting timeout on validation, while debugging with JMeter keep getting exception in Connection constructor while calling socket.getInputStream():

java.io.EOFException
	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2681)
	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3156)
	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:862)
	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:358)
	at com.codegym.task.task30.task3008.Connection.<init>(Connection.java:16)
	at com.codegym.task.task30.task3008.Server$Handler.run(Server.java:25)

What am I doing wrong?

It's time to write the main method of the Handler class, which will call all
the helper methods we wrote earlier. Implement the void run() method in the Handler class.

It must:
1) Display a message indicating that a new connection was established with a remote
address that can be obtained using the getRemoteSocketAddress() method.
2) Create a Connection object using the socket field.
3) Call the method that implements the handshake with the client, and store the name of the new client.
4) Send the name of the new participant (USER_ADDED message) to all chat participants.
Think about which method is most suitable for this.
5) Inform the new participant about the existing participants.
6) Start the server's main message-processing loop.
7) Be sure that the connection is closed if an exception occurs.
8) If any IOExceptions or ClassNotFoundExceptions occur, catch them and display a message indicating
that an error occurred while communicating with the remote address. 9) After handling any exceptions, if step 11.3 has finished and returned a name, we need to remove
from connectionMap the entry for that name and send a USER_REMOVED message containing the name to all other participants.
10) The last thing we need to do in the run() method is display a message
indicating that the connection with the remote address is closed.

Our server is completely ready. Try running it.

Requirements:

The run() method should display a message indicating that a connection has been established with the remote address (use the getRemoteSocketAddress() method).
The run() method should create a new connection using the socket field as an argument.
The run() method should call the serverHandshake() method using the newly created connection as an argument; the return value will be the username (userName).
The run() method should call the sendBroadcastMessage() method using a new message as an argument (MessageType.USER_ADDED, userName).
The run() method should call the notifyUsers() method using connection and userName as arguments.
The run() method should call the serverMainLoop() method using connection and userName as arguments.
Before completing, the run() method must remove from connectionMap the entry that corresponds to userName, and send a message to all chat participants that the current user has been removed.
The run() method should correctly handle IOExceptions and ClassNotFoundExceptions.

package com.codegym.task.task30.task3008; import java.io.IOException; import java.net.ServerSocket; import java.net.Socket; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; public class Server { private static Map<String, Connection> connectionMap = new ConcurrentHashMap<>(); private static class Handler extends Thread { private Socket socket; public Handler(Socket socket) { this.socket = socket; } @Override public void run() { String userName = null; Connection connection = null; try { connection = new Connection(socket); ConsoleHelper.writeMessage("Connection established with remote address: " + connection.getRemoteSocketAddress()); userName = serverHandshake(connection); sendBroadcastMessage(new Message(MessageType.USER_ADDED, userName)); notifyUsers(connection, userName); //serverMainLoop(connection, userName); } catch (IOException e) { ConsoleHelper.writeMessage("Error occured while communicating with remote address"); if (connection != null) { try { connection.close(); } catch (IOException ec) {} } if (userName != null) { connectionMap.remove(userName); sendBroadcastMessage(new Message(MessageType.USER_REMOVED, userName)); } ConsoleHelper.writeMessage("Connection with the remote address is closed."); } //catch (ClassNotFoundException e) { // ConsoleHelper.writeMessage("Error occured while communicating with remote address"); // } } private String serverHandshake(Connection connection) throws IOException { Message message = new Message(MessageType.NAME_REQUEST); Message receivedMessage = null; do { connection.send(message); try { receivedMessage = connection.receive(); } catch (ClassNotFoundException e) { } } while (receivedMessage == null || !receivedMessage.getType().equals(MessageType.USER_NAME) || receivedMessage.getData() == null || receivedMessage.getData().isEmpty() || connectionMap.containsKey(receivedMessage.getData()) ); connectionMap.put(receivedMessage.getData(), connection); connection.send(new Message(MessageType.NAME_ACCEPTED)); return receivedMessage.getData(); } private void notifyUsers(Connection connection, String userName) throws IOException { connectionMap.forEach((u, c) -> { if (!u.equals(userName)) { try { connection.send(new Message(MessageType.USER_ADDED, u)); } catch (IOException e) { ConsoleHelper.writeMessage("Can't send message to '" + userName + "'"); e.printStackTrace(); } } }); } private void serverMainLoop(Connection connection, String userName) throws IOException, ClassNotFoundException { while (true) { try { Message received = connection.receive(); if (received.getType().equals(MessageType.TEXT)) { String m = userName + ": " + received.getData(); sendBroadcastMessage(new Message(MessageType.TEXT, m)); } else { String error = "not text error"; ConsoleHelper.writeMessage(error); } } catch (Exception e) { ConsoleHelper.writeMessage(e.getMessage()); } } } } public static void main(String[] args) { ConsoleHelper.writeMessage("Please, enter server port:"); int port = ConsoleHelper.readInt(); ServerSocket serverSocket = null; try { serverSocket = new ServerSocket(port); } catch (IOException e) { e.printStackTrace(); } System.out.println("Server is listening on port " + port); try { Socket socket; while ((socket = serverSocket.accept()) != null) { new Handler(socket).start(); } } catch (IOException e) { System.out.println(e.getMessage()); e.printStackTrace(); } finally { try { serverSocket.close(); } catch (IOException e) { e.printStackTrace(); } } } public static void sendBroadcastMessage(Message message) { for (Map.Entry<String, Connection> connectionEntry : connectionMap.entrySet()) { try { connectionEntry.getValue().send(message); } catch (IOException e) { System.out.println("Can't send mesage to user '" + connectionEntry.getKey() + "'"); e.printStackTrace(); } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Павел Артеменко

Level 41 , Krasnodar, Russian Federation

12 May 2019, 15:39

Messed up in run() method - solved.

Andrew

Level 29 , Seattle, United States

21 May 2019, 17:55

What did you change?

Павел Артеменко

Level 41 , Krasnodar, Russian Federation

21 May 2019, 18:15

public void run() {
	String userName = null;
	Connection connection = null;

	do {
		try {
			ConsoleHelper.writeMessage("New connection was established with a remote address " + socket.getRemoteSocketAddress());
			connection = new Connection(socket);
		} catch (Exception ig) {
			break;
		}
		try {
			userName = serverHandshake(connection);
		} catch (Exception ig) {
			try {
				connection.close();
			} catch (IOException e) {
				e.printStackTrace();
			}
			break;
		}
		try {
			sendBroadcastMessage(new Message(MessageType.USER_ADDED, userName));
			notifyUsers(connection, userName);
			serverMainLoop(connection, userName);
		} catch (Exception e) {
		} finally {
			connectionMap.remove(userName);
			sendBroadcastMessage(new Message(MessageType.USER_REMOVED, userName));
			try {
				connection.close();
			} catch (IOException e1) {
				e1.printStackTrace();
			}
		}
	} while (false);
	ConsoleHelper.writeMessage("Connection closed: " + socket.getRemoteSocketAddress());
}