I can`t understand where is problem. Can you help me please.

Question about the task

Cat relations

Java Syntax, Level 6, Lesson 11

Resolved

I can`t understand why the last two conditions no are right.

Task: Each cat has a name and a mother.
Create a class that describes this situation.
Create two objects: a daughter cat and a mother.
Display them on the screen.

New task: Each cat has a name, a father, and a mother.
Edit Cat so that it reflects these relationships.
Create 6 objects: grandfather (the father's father), grandmother (the mother's mother), father, mother, son, daughter.
Display them all in the following order: grandfather, grandmother, father, mother, son, daughter.

Example input:
Grandfather Tiger Grandmother Puss Father Oscar Mother Missy Son Simba Daughter Coco

Example output:
The cat's name is Grandfather Tiger, no mother, no father The cat's name is Grandmother Puss, no mother, no father The cat's name is Father Oscar, no mother, Grandfather Tiger is the father The cat's name is Mother Missy, Grandmother Puss is the mother, no father The cat's name is Son Simba, Mother Missy is the mother, Father Oscar is the father The cat's name is Daughter Coco, Mother Missy is the mother, Father Oscar is the father

Requirements:

The program should read in the names of 6 cats in the specified order.
The main method should create 6 Cat objects.
The program should display 6 lines with information about the cats.
The line about the grandfather (first line) must match the conditions.
The line about the grandmother (second line) must match the conditions.
The line about the father (third line) must match the conditions.
The line about the mother (fourth line) must match the conditions.
The line about the son (fifth line) must match the conditions.
The line about the daughter (sixth line) must match the conditions.

package com.codegym.task.task06.task0621; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; /* Cat relations */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String grandfatherName = reader.readLine(); Cat catGrandfather = new Cat(grandfatherName,null,null); String grandmotherName = reader.readLine(); Cat catGrandmother = new Cat(grandmotherName,null, null); String fatherName = reader.readLine(); Cat catFather = new Cat(fatherName,catGrandfather, null); String motherName = reader.readLine(); Cat catMother = new Cat(motherName,null, catGrandmother); String sonName = reader.readLine(); Cat catSon = new Cat(sonName, catFather, catMother); String daughterName = reader.readLine(); Cat catDaughter = new Cat(daughterName, catFather, catMother); System.out.println(catGrandfather); System.out.println(catGrandmother); System.out.println(catFather); System.out.println(catMother); System.out.println(catSon); System.out.println(catDaughter); } public static class Cat { private String name; private Cat mother; private Cat father; Cat(String name) { this.name = name; } Cat(String name, Cat father, Cat mother) { this.name = name; this.father = father; this.mother = mother; } @Override public String toString() { if (mother == null && father!=null) { return "The cat's name is " + name + ", no mother, " +this.father.name+" is the father"; } else if (father==null && mother!=null) { return "The cat's name is " + name + ", " + this.mother.name + " is the mother" + ", no father"; } else if (father != null && mother != null) { return "The cat`s name is " + name + ", " + this.mother.name + " is the mother, " + this.father.name + " is the father"; } else { return "The cat's name is " + name + ", " + "no mother, " + "no father"; } } } } //he cat's name is Son Simba, Mother Missy is the mother, Father Oscar is the father //The cat's name is Daughter Coco, Mother Missy is the mother, Father Oscar is the father

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Boris Penchev

Level 8 , Sofia, Bulgaria

7 October 2019, 13:37

Thank you, Guadalupe Gagnon, this helps me.

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 13:28

solution

Check line 66, you are using a ` instead of an '. (that is a 'grave accent' instead of an 'apostrophe')

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 13:33

Also, instead of using a ton of 'if-else if' statements that all return basically the same info, I suggest using a method more like this to keep the typing down, plus since it is all using the same string, if there are mistakes it is easier to correct:

public String toString() {
   String mom;
   String dad;

   if(mother == null)
      mom = "no";
   else
      mom = mother.name + " is the";

   if(father == null)
      dad = "no";
   else
      dad = father.name + " is the";


   return "The cat's name is " + name + " mother, "+ mom +", " + dad + " father";


}

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 13:41

I think the above method is cleaner, however if you want less lines of code you could do this: .

public String toString() {
            String mom = "no";
            String dad = "no";

            if(mother != null)
                mom = mother.name + " is the";

            if(father != null)
                dad = father.name + " is the";

            return "The cat's name is " + name + " mother, "+ mom +", " + dad + " father";
        }

. or .

public String toString() {
            return "The cat's name is " + name + " mother, "+ (mother == null ? "no": mother.name + " is the") +", "
                    + (father == null ? "no":father.name+ " is the") + " father";
        }

Gabriella LaPlace

Level 16 , Basseterre, Saint Kitts and Nevis

7 October 2019, 12:04