Output is ok, but still not completing all conditions

Question about the task

R or L

Java Syntax, Level 7, Lesson 9

Under discussion

i do not understand why!

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; import java.lang.*; import java.util.Collections; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("love"); // 1 list.add("lyre"); // 2 list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { for(int i = 0; ; i++){ if(list.get(i).contains("r") && list.get(i).contains("l")){ ; } if(list.get(i).contains("r") && !list.get(i).contains("l")){ list.remove(i); } if(list.get(i).contains("l") && !list.get(i).contains("r")) { list.add(i+1, list.get(i)); } break; } Collections.reverse(list); return list; } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Andrei Varcus

Level 11 , Arad, Romania

21 November 2019, 13:47

it was easier than I expected!...I cannot believe this task took me 3 days to complete.

for(int i = 0; i < list.size(); i++){

    if(list.get(i).contains("l") && !list.get(i).contains("r")) {
        list.add(i, list.get(i));
        i++;
    }
    if(list.get(i).contains("r") && !list.get(i).contains("l")){
        list.remove(i);
        i--;
    }

}

before it was list.remove if and afterwards list.add if and it didnt work..but switching them it works

Anthony Chalk

Level 30 , London, United Kingdom

21 November 2019, 09:43

useful

I tried your code but changed the elements to: ll rr rr, the out put was: rr rr ll ll Remember, your code should work for all values, not just the ones provided in the task. First off, get rid of line 41 and line 38. Secondly, try changing line 27 to:

for (int i = 0; i <list.size(); i++)

This way you can be sure that you're iterating through the whole list. And remember, if you duplicate or remove an element, the index of the following elements will change, be sure to add i++ if the condition for duplicating is fulfilled, and i-- if the condition for removing is fulfilled Edit: Less important, but you can get rid of the first condition, by default the program won't do anything if it contains both as you specify in the other conditions that it's only if the element doesn't contain the other letter