Stuck on the 4th requirement!

Question about the task

CashMachine (part 8)

Java Collections, Level 9, Lesson 15

Under discussion

Are there other ways I can check if these are numbers or not in the depositCommand?

It's time to whip our main method into shape. It already has a bunch of stuff that shouldn't be there.

1. Move the logic from main to DepositCommand and InfoCommand.
So what's happened to main? We have a loop, in which we ask the user for an operation and then call a method on the CommandExecutor.
And so on forever... You need to come up the exit condition for the loop.
Correct the loop to make it a do-while. The exit condition is the EXIT operation.

2. Let's run the program and top up the account with "EUR 100 2" and "USD 20 6". Then we'll look at INFO.
It's not clear what to do, since we've created 2 manipulators: the first for EUR, the second for USD.
Let's improve the logic of InfoCommand. We need to display the balance for each manipulator.

2.1. In the CurrencyManipulatorFactory class, create a static getAllCurrencyManipulators() method that returns a Collection of all manipulators.
You stored all the manipulators in a map, right? If not, then refactor.
2.2. In InfoCommand, display "<currency code> - <total amount of money for the selected currency>".
Let's run the program and top up the account with "EUR 100 2" and "USD 20 6". Then we'll look at INFO.

Does everything work correctly?

EUR - 200
USD - 120

Excellent!

3. Run the program and immediately request the INFO operation as the first operation. Nothing is displayed? That's no good.
Add a boolean hasMoney() method to the manipulator. It should indicate whether any banknotes have been added.

4. In InfoCommand, use the method in item 3 and display "No money available." if there is no money in the ATM.

Requirements:

There should be a public static Collection<CurrencyManipulator> getAllCurrencyManipulators() method in the CurrencyManipulatorFactory class.
The CurrencyManipulator class should have a boolean hasMoney() method.
In the InfoCommand class's execute() method, for each manipulator, display: "<currency code> - <total amount of money for the selected currency>"; if there's no money in the ATM, display "No money available.".
In the DepositCommand class's execute() method, request the currency code, then request the denomination and number of banknotes, and then add them to the manipulator. If the user enters an invalid denomination or number of banknotes (i.e. values that are not numbers), repeat the request for the denomination and number of banknotes.
In the CashMachine class's main method, request an operation from the user. Perform the operation in CommandExecutor. Repeat until the user selects the EXIT operation.

package com.codegym.task.task26.task2613; public enum Operation { INFO, DEPOSIT, WITHDRAW, EXIT; public static Operation getAllowableOperationByOrdinal(Integer i){ if (i == null) throw new IllegalArgumentException(); switch(i){ case 1: return INFO; case 2: return DEPOSIT; case 3: return WITHDRAW; case 4: return EXIT; default: throw new IllegalArgumentException(); } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Olek

Level 41 , Amsterdam, Netherlands

24 February 2020, 21:24

Hi Alexandre, Try this code:

while (true){
try{
    String[] banknotes = ConsoleHelper.getTwoValidNumbers(currencyCode);
    den = Integer.parseInt(banknotes[0]);
    count = Integer.parseInt(banknotes[1]);
    break;
} catch (NumberFormatException e){
    ConsoleHelper.writeMessage(res.getString("invalid.data"));
}
}
currencyManipulator.addAmount(den,count);